Review main Merged

62170[BUGFIX] Allow usage of uid in slug generation via Ajax

Johannes Schlier CR +2 V +2 Easy +11 −1 updated 11/09/19, 16:36

Commit message

This commit adds an option to the slug input type which allows it
to use the uid of a record when the update slug button is pressed
in the FormEngine.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Wolfgang Klinger +1
    • Susi Moog +1
    • Daniel Sattler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1113

  1. Johannes Schlier uploaded patch set 1 10/31/19, 12:18

  2. TYPO3com voted on patch set 1 V -1 10/31/19, 12:31 Completed build in 13m 25s on Thu, 31 Oct, 12:31 PM Test Summary: 1 of 48350 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37898

  3. Oli Bartsch commented on patch set 1 V -1 10/31/19, 16:59

    The corresponding JavaScript file (typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SlugElement.js) is missing.
  4. Johannes Schlier uploaded patch set 2 11/04/19, 09:13

  5. Daniel Sattler voted on patch set 2 CR +1 11/04/19, 09:24

  6. TYPO3com voted on patch set 2 V +1 11/04/19, 09:30 Completed build in 16m 25s on Mon, 4 Nov, 09:30 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37958

  7. Oli Bartsch voted on patch set 2 CR +1 11/04/19, 09:43

  8. Wolfgang Klinger voted on patch set 2 CR +1 11/05/19, 12:17

  9. Oli Bartsch voted on patch set 2 V +1 11/09/19, 16:08

  10. Susi Moog voted on patch set 2 CR +1 11/09/19, 16:20

  11. Susi Moog voted on patch set 2 V +1 11/09/19, 16:34

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 11/09/19, 16:36

  13. Andreas Kienast merged patch set 3 11/09/19, 16:36