62171[BUGFIX] Add check if update of all language packs is possible
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Andreas Kienast +1
-
Verified V +2 Done
- Frank Nägler +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2139
Show 814 earlier messages
-
Oli Bartsch uploaded patch set 1 10/31/19, 13:26
-
TYPO3com voted on patch set 1 V -1 10/31/19, 13:39 Completed build in 12m 36s on Thu, 31 Oct, 01:39 PM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37900
-
TYPO3com voted on patch set 1 V +1 10/31/19, 13:51 Completed build in 12m 05s on Thu, 31 Oct, 01:51 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37902
-
Oli Bartsch updated the commit message in patch set 2 10/31/19, 13:55
-
TYPO3com voted on patch set 2 V -1 10/31/19, 14:04 Completed build in 09m 01s on Thu, 31 Oct, 02:04 PM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37903
-
TYPO3com voted on patch set 2 V +1 10/31/19, 14:17 Completed build in 10m 44s on Thu, 31 Oct, 02:17 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37904
-
Georg Ringer commented on patch set 2 CR -1 11/01/19, 19:05
this commit msg looks really wrong because it looks that update language packs is a bad idea and must be stopped... maybe something like "Add check if update of language packs is required"? -
Oli Bartsch updated the commit message in patch set 3 11/01/19, 20:17
-
Oli Bartsch commented on patch set 3 11/01/19, 20:18
Thanks @Georg, you're right. I took your's, which describes the patch much better.Reply
Done -
Georg Ringer commented on patch set 3 11/01/19, 20:26
LanguagePacks.ts:271shouldn't that be more an information, not having any languages isn't a bad thing?! -
TYPO3com voted on patch set 3 V +1 11/01/19, 20:32 Completed build in 11m 10s on Fri, 1 Nov, 08:32 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37920
-
Oli Bartsch uploaded patch set 4 11/02/19, 08:29
-
Oli Bartsch commented on patch set 4 11/02/19, 08:29
LanguagePacks.ts:271ReplyDone -
TYPO3com voted on patch set 4 V -1 11/02/19, 08:40 Completed build in 10m 57s on Sat, 2 Nov, 08:40 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37921
-
TYPO3com commented on patch set 4 11/02/19, 09:23 Completed build in 14m 00s on Sat, 2 Nov, 09:23 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37924
-
TYPO3com commented on patch set 4 11/02/19, 09:36 Completed build in 10m 36s on Sat, 2 Nov, 09:36 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37925
-
TYPO3com commented on patch set 4 11/02/19, 11:23 Completed build in 09m 47s on Sat, 2 Nov, 11:23 AM Test Summary: 47827 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37926
-
TYPO3com commented on patch set 4 11/02/19, 14:40 Completed build in 09m 50s on Sat, 2 Nov, 02:40 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37927
-
Oli Bartsch uploaded patch set 5 11/02/19, 17:10
-
TYPO3com voted on patch set 5 V +1 11/02/19, 17:20 Completed build in 09m 42s on Sat, 2 Nov, 05:20 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37930
-
Oli Bartsch uploaded patch set 6 11/08/19, 13:11
-
TYPO3com voted on patch set 6 V +1 11/08/19, 13:22 Completed build in 10m 30s on Fri, 8 Nov, 01:22 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38112
-
Oli Bartsch uploaded patch set 7 11/25/19, 11:49
-
TYPO3com voted on patch set 7 V +1 11/25/19, 11:57 Completed build in 07m 23s on Mon, 25 Nov, 11:57 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38820
-
Andreas Kienast commented on patch set 7 11/25/19, 12:15
Doesn't it even make more sense to toggle the "Update all" button? -
Oli Bartsch commented on patch set 7 11/25/19, 19:03
> Patch Set 7: > > Doesn't it even make more sense to toggle the "Update all" button? You mean disable it, do you? I looked into this some time ago but AFAIR the information isn’t available there. So we would need some more code to check initially if there is at least one language pack installed. Thought it would be enough for now to just early return. So what’s your opinion, should I rework this? -
Ghanshyam Bhava voted on patch set 7 V +1 11/28/19, 16:09
-
Oli Bartsch uploaded patch set 8 12/06/19, 08:47
-
TYPO3com voted on patch set 8 V -1 12/06/19, 08:55 Completed build in 07m 31s on Fri, 6 Dec, 08:55 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39132
-
TYPO3com commented on patch set 8 12/06/19, 09:07 Completed build in 06m 56s on Fri, 6 Dec, 09:07 AM Test Summary: 68211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39133
-
TYPO3com commented on patch set 8 12/06/19, 09:32 Completed build in 08m 07s on Fri, 6 Dec, 09:32 AM Test Summary: 68762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39136
-
Oli Bartsch uploaded patch set 9 12/06/19, 09:45
-
TYPO3com voted on patch set 9 V +1 12/06/19, 09:53 Completed build in 07m 40s on Fri, 6 Dec, 09:53 AM Test Summary: 68763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39139
-
Andreas Kienast voted on patch set 9 V +1 CR +1 12/06/19, 15:21
-
Andreas Kienast uploaded patch set 10 12/06/19, 15:22
-
Andreas Kienast voted on patch set 10 V +1 CR +1 12/06/19, 15:22
-
TYPO3com voted on patch set 10 V +1 12/06/19, 15:29 Completed build in 07m 17s on Fri, 6 Dec, 03:29 PM Test Summary: 68730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39176
-
Frank Nägler voted on patch set 10 V +2 CR +2 12/06/19, 15:32
-
Frank Nägler merged patch set 11 12/06/19, 15:33