Review main Merged

62172[BUGFIX] Do not add entries to cache_treelist when logged into BE

Benni Mack CR +2 V +2 Easy +10 −6 updated 11/20/19, 14:31

Commit message

When accessing cache_treelist / cObj->getTreeList()
this information should not be cached at all when logged
into the backend at the same time. This would then result
in wrong lists of IDs.

As treelist is conceptually wrong on a various number of levels,
a short workaround is added so the cache is never written
when accessing the Frontend and having a valid $GLOBALS['BE_USER']
object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Frank Nägler +1
    • Daniel Gorges +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Benni Mack uploaded patch set 1 10/31/19, 15:53

  2. TYPO3com voted on patch set 1 V +1 10/31/19, 16:04 Completed build in 10m 30s on Thu, 31 Oct, 04:04 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37909

  3. Oli Bartsch voted on patch set 1 CR +1 11/01/19, 13:21

  4. Frank Nägler voted on patch set 1 CR +1 11/08/19, 13:39

  5. Guido Schmechel voted on patch set 1 CR +1 11/09/19, 10:12

  6. Susi Moog voted on patch set 1 V +1 CR +1 11/19/19, 12:45

  7. Susi Moog commented on patch set 1 11/19/19, 12:45

    (can easily be tested with xml sitemaps for example)
  8. Daniel Gorges voted on patch set 1 V +1 CR +1 11/20/19, 14:22

  9. Benni Mack voted on patch set 1 V +2 CR +2 11/20/19, 14:31

  10. Benni Mack merged patch set 2 11/20/19, 14:31