62174[BUGFIX] Pluralize term dynamically
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Daniel Goerz +1
- Georg Ringer +1
-
Verified V +2 Done
- Frank Nägler +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 78
-
Oli Bartsch uploaded patch set 1 11/01/19, 11:22
-
TYPO3com voted on patch set 1 V +1 11/01/19, 11:32 Completed build in 10m 07s on Fri, 1 Nov, 11:32 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37916
-
Mathias Brodala commented on patch set 1 11/01/19, 12:14
Notice that this is only the tip of the iceberg and will cover a few languages. If you want to cover all languages and their many plural forms (https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html), you'll need an external library. -
Oli Bartsch commented on patch set 1 11/01/19, 12:28
> Patch Set 1: > > Notice that this is only the tip of the iceberg and will cover a few languages. If you want to cover all languages and their many plural forms (https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-forms.html), you'll need an external library. Thanks for your hint! As the labels are currently static and only in english, I think it is sufficient in this case and adding a external library would be overload (now). But your totally right. If the cards labels will ever get localized we must also adjust this function. -
Georg Ringer commented on patch set 1 V +1 CR +1 11/01/19, 19:11
something like Intl.PluralRules would get handy there, or maybe we would switch to something like "updated language packs:1" to avoid such stuff. we could do that now already as well -
Daniel Goerz voted on patch set 1 CR +1 11/04/19, 09:32
-
Frank Nägler voted on patch set 1 V +2 CR +2 11/08/19, 12:17
-
Frank Nägler merged patch set 2 11/08/19, 12:17