Review main Abandoned

62176[BUGFIX] Respect transOrigPointerField at localization of records

Oli Bartsch CR 0 V 0 Easy +27 −5 updated 01/25/20, 09:18

Commit message

Now the `transOrigPointerField` is respected for non-admin backend users
at localization of records. Without these checks, the backend users
were able to translate records but only inconsistent data were stored
in the database. Also the created translation wasn't shown in the
backend at all. Not even for admin users.

Moreover no user was able to create a working translation anymore,
because the one with inconsistent data was already present in the database.
This leads to errors on further translation attempts.

Therefore the checks are introduced to following places:
* Pages language selector in both page and list module
* "Localize to" column in the list module
* Selector box in the DocHeader of the EditDocument form
* "Translate" option inside "Localize into" modal in the page module

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 913

  1. Oli Bartsch uploaded patch set 1 11/02/19, 23:56

  2. Oli Bartsch updated the commit message in patch set 2 11/02/19, 23:57

  3. Oli Bartsch uploaded patch set 3 11/03/19, 00:02

  4. TYPO3com voted on patch set 1 V +1 11/03/19, 00:07 Completed build in 11m 37s on Sun, 3 Nov, 12:07 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37932

  5. TYPO3com voted on patch set 2 V -1 11/03/19, 00:10 Completed build in 13m 12s on Sun, 3 Nov, 12:10 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37933

  6. Oli Bartsch updated the commit message in patch set 4 11/03/19, 00:14

  7. TYPO3com voted on patch set 3 V +1 11/03/19, 00:15 Completed build in 12m 02s on Sun, 3 Nov, 12:15 AM Test Summary: 48078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37934

  8. TYPO3com voted on patch set 4 V +1 11/03/19, 00:25 Completed build in 10m 22s on Sun, 3 Nov, 12:25 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37935

  9. Steffen Frese voted on patch set 4 CR +1 01/17/20, 06:16

  10. Sascha Rademacher voted on patch set 4 CR +1 01/17/20, 09:29

  11. Benni Mack commented on patch set 4 CR -1 01/17/20, 17:39

    I suggest proceeding with this change instead (also for 9.5) https://review.typo3.org/c/Packages/TYPO3.CMS/+/62632
  12. Daniel Goerz commented on patch set 4 01/25/20, 09:13

    Hi Oliver, are you OK with abandoning this change and focus on the other one to get this fixed?
  13. Oli Bartsch abandoned the change 01/25/20, 09:18