Review main Merged

62177[BUGFIX] Fix parameter descriptions of bulkInsert

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 11/04/19, 10:30

Commit message

The `$data` array can contain column-value pairs or just the values.
The `$columns` array only contains the column names.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 915

  1. Oli Bartsch uploaded patch set 1 11/03/19, 00:42

  2. TYPO3com voted on patch set 1 V -1 11/03/19, 00:51 Completed build in 09m 44s on Sun, 3 Nov, 12:51 AM Test Summary: 47849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37936

  3. TYPO3com voted on patch set 1 V +1 11/03/19, 01:15 Completed build in 10m 08s on Sun, 3 Nov, 01:15 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37937

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/03/19, 20:33

  5. Stefan Froemken commented on patch set 1 CR -1 11/04/19, 07:47

    Connection.php:211

    The column names should not be inserted into the data, it's more a <An array containing the column names of the data which should be inserted>
  6. Oli Bartsch uploaded patch set 2 11/04/19, 07:58

  7. Oli Bartsch uploaded patch set 3 11/04/19, 07:59

  8. Oli Bartsch commented on patch set 3 11/04/19, 07:59

    Thanks, adjusted it accordingly.

    Connection.php:211 Reply

    Done
  9. TYPO3com voted on patch set 2 V -1 11/04/19, 08:09 Completed build in 11m 06s on Mon, 4 Nov, 08:09 AM Test Summary: 2 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37953

  10. TYPO3com voted on patch set 3 V -1 11/04/19, 08:13 Completed build in 13m 35s on Mon, 4 Nov, 08:13 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37954

  11. TYPO3com commented on patch set 3 11/04/19, 08:29 Completed build in 10m 13s on Mon, 4 Nov, 08:29 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37955

  12. TYPO3com voted on patch set 3 V +1 11/04/19, 08:41 Completed build in 10m 03s on Mon, 4 Nov, 08:41 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37956

  13. Daniel Goerz voted on patch set 3 V +1 CR +1 11/04/19, 09:22

  14. Benni Mack voted on patch set 3 V +2 CR +2 11/04/19, 10:30

  15. Benni Mack merged patch set 4 11/04/19, 10:30