Review main Merged

62178[BUGFIX] Check parsed url for query part in BE Shortcuts

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 11/05/19, 15:59

Commit message

This change adds null coalescing operators at multiple places
in `ShortcutRepository` to avoid type errors if the shortcut url
doesn't contain a query part (e.g. coming from legacy URLs
when a TYPO3 v7 installation was migrated).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 611

  1. Oli Bartsch uploaded patch set 1 11/03/19, 11:13

  2. TYPO3com voted on patch set 1 V +1 11/03/19, 11:24 Completed build in 10m 59s on Sun, 3 Nov, 11:24 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37939

  3. Oli Bartsch uploaded patch set 2 11/03/19, 20:30

  4. TYPO3com voted on patch set 2 V -1 11/03/19, 20:40 Completed build in 09m 50s on Sun, 3 Nov, 08:40 PM Test Summary: 47836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37949

  5. TYPO3com commented on patch set 2 11/03/19, 20:56 Completed build in 09m 11s on Sun, 3 Nov, 08:56 PM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37950

  6. Benni Mack updated the commit message in patch set 3 11/03/19, 20:57

  7. TYPO3com voted on patch set 3 V -1 11/03/19, 21:07 Completed build in 09m 37s on Sun, 3 Nov, 09:07 PM Test Summary: 48078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37951

  8. TYPO3com voted on patch set 3 V +1 11/03/19, 21:15 Completed build in 27m 55s on Sun, 3 Nov, 09:15 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37951

  9. Benni Mack voted on patch set 3 V +1 CR +1 11/04/19, 12:59

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 11/05/19, 15:59

  11. Daniel Goerz merged patch set 4 11/05/19, 15:59