Review main Merged

62179[BUGFIX] Consider all elements in typo3temp/assets/ when clearing

Oliver Hader CR +2 V +2 Normal +88 −4 updated 11/09/19, 15:41

Commit message

Only first level elements were considered when clearing assets in
typo3temp/assets/ using corresponding functionality in maintenance
section of the TYPO3 install tool.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1924

  1. Oliver Hader uploaded patch set 1 11/03/19, 11:18

  2. TYPO3com voted on patch set 1 V +1 11/03/19, 11:27 Completed build in 09m 20s on Sun, 3 Nov, 11:27 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37940

  3. Simon Gilli commented on patch set 1 11/03/19, 11:45

    imho some more tests would be nice see comments

    Typo3tempFileService.php:135 Unresolved

    There is not test for this exception

    Typo3tempFileService.php:143 Unresolved

    Also there are no tests for the whole clearing functionality
  4. Oliver Hader commented on patch set 1 11/03/19, 12:53

    > imho some more tests would be nice see comments Thanks for your feedback! What kind of test would you suggest here and what should they test/assert for?
  5. Oliver Hader uploaded patch set 2 11/03/19, 13:36

  6. TYPO3com voted on patch set 2 V -1 11/03/19, 13:46 Completed build in 09m 51s on Sun, 3 Nov, 01:46 PM Test Summary: 47840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37942

  7. Oliver Hader uploaded patch set 3 11/03/19, 13:48

  8. Oliver Hader uploaded patch set 4 11/03/19, 13:50

  9. TYPO3com voted on patch set 4 V -1 11/03/19, 14:01 Completed build in 11m 01s on Sun, 3 Nov, 02:01 PM Test Summary: 10 of 48444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37944

  10. TYPO3com voted on patch set 4 V +1 11/03/19, 14:03 Completed build in 24m 21s on Sun, 3 Nov, 02:03 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37944

  11. Oli Bartsch commented on patch set 4 V -1 11/03/19, 16:42

    In my test the subdirectories including their files are now removed. But now the files directly in `typo3temp/assets/compressed` are not removed anymore. My test setup is following: * typo3temp/assets/compressed/merged-XXX.css * typo3temp/assets/compressed/merged-XXX.css * typo3temp/assets/compressed/require-XXX.js * typo3temp/assets/compressed/css/test.css * typo3temp/assets/compressed/images/test.jpg * typo3temp/assets/compressed/docs/test.txt Without this patch following files were removed: * typo3temp/assets/compressed/merged-XXX.css * typo3temp/assets/compressed/merged-XXX.css * typo3temp/assets/compressed/require-XXX.js With this patch following files were removed (including the directories): * typo3temp/assets/compressed/css/test.css * typo3temp/assets/compressed/images/test.jpg * typo3temp/assets/compressed/docs/test.txt
  12. Simon Gilli commented on patch set 4 11/03/19, 17:44

    > Patch Set 1: > > > imho some more tests would be nice see comments > > Thanks for your feedback! What kind of test would you suggest here and what should they test/assert for? I think that question is already answered by my two other comments and you did it like expected ;)

    Typo3tempFileServiceTest.php:53

    imo this test should go into the existing unit test
  13. Simon Gilli commented on patch set 4 11/03/19, 18:08

    Typo3tempFileServiceTest.php:53 Reply

    or move the existing two to this functional test, I'm not sure
  14. Benni Mack commented on patch set 4 CR -1 11/04/19, 15:16

    Typo3tempFileServiceTest.php:2 Unresolved

    strict typing is missing
  15. Susi Moog uploaded patch set 5 11/09/19, 14:44

  16. Susi Moog commented on patch set 5 11/09/19, 14:46

    Typo3tempFileServiceTest.php:53 Reply

    as those tests rely on the file system, we should probably move the other two to this class in another patch.
  17. Benni Mack commented on patch set 5 11/09/19, 14:49

    Typo3tempFileServiceTest.php:53 Reply Unresolved

    sounds like a plan
  18. TYPO3com voted on patch set 5 V +1 11/09/19, 14:52 Completed build in 07m 36s on Sat, 9 Nov, 02:52 PM Test Summary: 48249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38189

  19. Benni Mack commented on patch set 5 V -1 11/09/19, 14:54

    This is nice - but: the layer shows a different file count than the amount of files that get deleted then!
  20. Benni Mack commented on patch set 5 V +1 11/09/19, 14:56

    ah, now it works!
  21. Benni Mack voted on patch set 5 CR +1 11/09/19, 15:25

  22. Daniel Goerz voted on patch set 5 CR +1 11/09/19, 15:36

  23. Susi Moog voted on patch set 5 V +2 CR +2 11/09/19, 15:41

  24. Susi Moog merged patch set 6 11/09/19, 15:41