Review main Merged

62181[DOCS] Fix explanation of content element TypoScript example

TYPO3com CR +2 V +2 Easy +1 −1 updated 11/06/19, 19:09

Commit message

The example makes use of a reference, not a copy. This is now reflected
by the text.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1520

  1. TYPO3com uploaded patch set 1 11/03/19, 14:24

  2. Oliver Hader commented on patch set 1 11/03/19, 14:28

    Actually the reference operator leads to a copy as well... * `<` is evaluated/copied during parse-time * `=<` is evaluated/copied during runtime when according cObject is about to be rendered Text might be adjusted, but keeping "references"...
  3. Oliver Hader voted on patch set 1 CR -1 11/03/19, 14:29

  4. TYPO3com voted on patch set 1 V -1 11/03/19, 14:33 Completed build in 09m 23s on Sun, 3 Nov, 02:33 PM Test Summary: 8 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37946

  5. Oli Bartsch updated the commit message in patch set 2 11/04/19, 09:52

  6. Oli Bartsch voted on patch set 2 CR +1 11/04/19, 09:53

  7. TYPO3com voted on patch set 2 V +1 11/04/19, 10:04 Completed build in 11m 38s on Mon, 4 Nov, 10:04 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37962

  8. Daniel Siepmann commented on patch set 2 V -1 CR -1 11/06/19, 07:03

    Index.rst:161

    This change looks wrong to me. EXT:fluid_styled_content is using `=<` so are we. Example (9.5): ``` # Typical content elements ### <INCLUDE_TYPOSCRIPT: source="FILE:EXT:fluid_styled_content/Configuration/TypoScript/ContentElement/Bullets.typoscript"> BEGIN: # Bullet List: # A single bullet list. # # CType: bullets tt_content.bullets =< lib.contentElement ```
  9. Daniel Siepmann uploaded patch set 3 11/06/19, 07:06

  10. Daniel Siepmann voted on patch set 3 V +1 CR +1 11/06/19, 07:06

  11. Daniel Siepmann commented on patch set 3 11/06/19, 07:07

    Index.rst:161 Reply

    I checked the original comment from GitHub https://github.com/TYPO3/TYPO3.CMS/pull/208#issue-336030144 and used his 2nd idea: Replace copy with reference in text instead.
  12. Oli Bartsch voted on patch set 3 V +1 CR +1 11/06/19, 07:11

  13. TYPO3com voted on patch set 3 V +1 11/06/19, 07:25 Completed build in 16m 31s on Wed, 6 Nov, 07:25 AM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38028

  14. Daniel Siepmann updated the commit message in patch set 4 11/06/19, 13:27

  15. Daniel Siepmann voted on patch set 4 V +1 CR +1 11/06/19, 13:28

  16. TYPO3com voted on patch set 4 V +1 11/06/19, 13:37 Completed build in 09m 25s on Wed, 6 Nov, 01:37 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38040

  17. Oli Bartsch voted on patch set 4 V +1 CR +1 11/06/19, 15:34

  18. Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 11/06/19, 19:08

  19. Tymoteusz Motylewski merged patch set 5 11/06/19, 19:09