62181[DOCS] Fix explanation of content element TypoScript example
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Oli Bartsch +1
- Daniel Siepmann +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Oli Bartsch +1
- Daniel Siepmann +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1520
-
TYPO3com uploaded patch set 1 11/03/19, 14:24
-
Oliver Hader commented on patch set 1 11/03/19, 14:28
Actually the reference operator leads to a copy as well... * `<` is evaluated/copied during parse-time * `=<` is evaluated/copied during runtime when according cObject is about to be rendered Text might be adjusted, but keeping "references"... -
Oliver Hader voted on patch set 1 CR -1 11/03/19, 14:29
-
Oliver Hader commented on patch set 1 11/03/19, 14:29
Besides that, please have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#bad-summary-lines-examples-vs-good-examples -
TYPO3com voted on patch set 1 V -1 11/03/19, 14:33 Completed build in 09m 23s on Sun, 3 Nov, 02:33 PM Test Summary: 8 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37946
-
Oli Bartsch updated the commit message in patch set 2 11/04/19, 09:52
-
Oli Bartsch voted on patch set 2 CR +1 11/04/19, 09:53
-
TYPO3com voted on patch set 2 V +1 11/04/19, 10:04 Completed build in 11m 38s on Mon, 4 Nov, 10:04 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37962
-
Daniel Siepmann commented on patch set 2 V -1 CR -1 11/06/19, 07:03
Index.rst:161This change looks wrong to me. EXT:fluid_styled_content is using `=<` so are we. Example (9.5): ``` # Typical content elements ### <INCLUDE_TYPOSCRIPT: source="FILE:EXT:fluid_styled_content/Configuration/TypoScript/ContentElement/Bullets.typoscript"> BEGIN: # Bullet List: # A single bullet list. # # CType: bullets tt_content.bullets =< lib.contentElement ``` -
Daniel Siepmann uploaded patch set 3 11/06/19, 07:06
-
Daniel Siepmann voted on patch set 3 V +1 CR +1 11/06/19, 07:06
-
Daniel Siepmann commented on patch set 3 11/06/19, 07:07
Index.rst:161ReplyI checked the original comment from GitHub https://github.com/TYPO3/TYPO3.CMS/pull/208#issue-336030144 and used his 2nd idea: Replace copy with reference in text instead. -
Oli Bartsch voted on patch set 3 V +1 CR +1 11/06/19, 07:11
-
TYPO3com voted on patch set 3 V +1 11/06/19, 07:25 Completed build in 16m 31s on Wed, 6 Nov, 07:25 AM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38028
-
Daniel Siepmann updated the commit message in patch set 4 11/06/19, 13:27
-
Daniel Siepmann voted on patch set 4 V +1 CR +1 11/06/19, 13:28
-
TYPO3com voted on patch set 4 V +1 11/06/19, 13:37 Completed build in 09m 25s on Wed, 6 Nov, 01:37 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38040
-
Oli Bartsch voted on patch set 4 V +1 CR +1 11/06/19, 15:34
-
Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 11/06/19, 19:08
-
Tymoteusz Motylewski merged patch set 5 11/06/19, 19:09