Review main Abandoned

62182[BUGFIX] Shortcuts with old syntax won't fail anymore

Benni Mack CR 0 V 0 Easy +2 −2 updated 11/03/19, 20:31

Commit message

When upgrading from an old TYPO3 installation (v7), the be_shortcuts
could still have old syntax where there are no query paramters in
shortcuts. In order to avoid TypeErrors this is solved by adding a
null coalescense parameter to path and or query string checks.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Benni Mack uploaded patch set 1 11/03/19, 19:54

  2. TYPO3com voted on patch set 1 V -1 11/03/19, 20:04 Completed build in 10m 00s on Sun, 3 Nov, 08:04 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37948

  3. Oli Bartsch commented on patch set 1 11/03/19, 20:25

    Hi Benni, unfortunately there is another issue (https://forge.typo3.org/issues/89533) with the same problem but not linked to this so I already submitted a patch to fix the issue. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/62178 Maybe we can bring them together somehow.
  4. Benni Mack abandoned the change 11/03/19, 20:31

    let's use your change.