Review main Merged

62183[TASK] Initialize TSFE language at an earlier stage

Benni Mack CR +2 V +2 Normal +63 −4 updated 11/07/19, 21:47

Commit message

The languageService and pageRenderer instantiate their
language / locale information at a very late point, allowing
to only use TSFE's language features when TypoScript was loaded.

However, since TYPO3 v10, the SiteLanguage information is always
present in an earlier stage, so the initialization can happen earlier.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 11/04/19, 09:12

  2. TYPO3com voted on patch set 1 V -1 11/04/19, 09:24 Completed build in 11m 43s on Mon, 4 Nov, 09:24 AM Test Summary: 5 of 48192 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37957

  3. Benni Mack uploaded patch set 2 11/04/19, 20:53

  4. TYPO3com voted on patch set 2 V +1 11/04/19, 21:04 Completed build in 10m 23s on Mon, 4 Nov, 09:04 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37992

  5. Georg Ringer voted on patch set 2 V +1 CR +1 11/05/19, 08:37

  6. Oli Bartsch voted on patch set 2 CR +1 11/05/19, 08:39

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 11/05/19, 15:50

  8. Daniel Goerz merged patch set 3 11/05/19, 15:50

  9. Oliver Hader voted on patch set 3 CR +1 11/07/19, 21:47