Review main Merged

62184[BUGFIX] Respect config.intTarget and extTarget in default ParseFunc

Benni Mack CR +2 V +2 Easy +6 −2 updated 11/17/19, 15:15

Commit message

Fluid Styled Content's "lib.parseFunc" always sets the extTarget (target for
external URLs) to the constant, but never considers config.extTarget anymore.

Same goes for the internal target, where target is never set, as
the target parameter is already filled.

The patch adds some minor inline information as well as
the proper values.

In the future, it would make sense to use the same target values
for config.*target (which is for ALL links and not just the ones in parseFunc)
which should be populated by the constants, and not have the constants
interfer into lib.parseFunc anymore.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 11/04/19, 20:39

  2. TYPO3com voted on patch set 1 V +1 11/04/19, 20:50 Completed build in 10m 57s on Mon, 4 Nov, 08:50 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37991

  3. Wolfgang Klinger commented on patch set 1 CR -1 11/05/19, 12:01

    ParseFunc.typoscript:25

    what does <= do? Did you mean =< here?
  4. Benni Mack commented on patch set 1 CR -1 11/09/19, 17:39

    will try to fix.

    ParseFunc.typoscript:25 Reply Unresolved

    correct!
  5. Benni Mack uploaded patch set 2 11/09/19, 17:57

  6. TYPO3com voted on patch set 2 V +1 11/09/19, 18:06 Completed build in 08m 53s on Sat, 9 Nov, 06:06 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38222

  7. Susi Moog voted on patch set 2 CR +1 11/09/19, 20:33

  8. Susi Moog voted on patch set 2 V +1 11/09/19, 20:47

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 11/17/19, 15:15

  10. Daniel Goerz merged patch set 3 11/17/19, 15:15