Review main Merged

62195[BUGFIX] IRRE: Create a correct original value identifier

Andreas Kienast CR +2 V +2 Easy +6 −1 updated 11/09/19, 18:02

Commit message

The value of `data-table-unique-original-value` was accidentally of type
array. This causes runtime errors since a string is expected.

This patch now creates a proper value passed to FormEngine to handle the
original unique value.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1013

  1. Andreas Kienast uploaded patch set 1 11/05/19, 12:46

  2. Markus Klein voted on patch set 1 CR +1 11/05/19, 12:49

  3. Andreas Kienast uploaded patch set 2 11/05/19, 12:53

  4. TYPO3com voted on patch set 1 V -1 11/05/19, 12:57 Completed build in 10m 58s on Tue, 5 Nov, 12:57 PM Test Summary: 1 of 48482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38005

  5. TYPO3com voted on patch set 2 V +1 11/05/19, 13:03 Completed build in 10m 04s on Tue, 5 Nov, 01:03 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38006

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 11/05/19, 13:15

  7. Markus Klein voted on patch set 2 CR +1 11/05/19, 14:34

  8. Guido Schmechel commented on patch set 2 11/09/19, 10:16

    InlineRecordContainer.php:192 Unresolved

    Does it make sense to put $data['inlineData']['unique'][$domObjectId . '-' . $foreignTable] in a variable? Then maybe we would have a better readability on the condition
  9. Andreas Kienast uploaded patch set 3 11/09/19, 17:16

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/09/19, 17:23

  11. TYPO3com voted on patch set 3 V +1 11/09/19, 17:24 Completed build in 08m 10s on Sat, 9 Nov, 05:24 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38209

  12. Susi Moog voted on patch set 3 V +2 CR +2 11/09/19, 18:02

  13. Susi Moog merged patch set 4 11/09/19, 18:02