Review main Merged

62197[BUGFIX] Explicitly initialize DateTime picker for form fields

Andreas Kienast CR +2 V +2 Easy +18 −14 updated 11/07/19, 11:42

Commit message

The InputDateTimeElement now takes an element identifier to initialize a
field as a date time picker. The DateTimePicker module now uses an
optional element identifier to render the date time picker.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Johannes Schlier +1
  • Verified V +2 Done
    • Benni Mack +2
    • Johannes Schlier +1
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 68

  1. Andreas Kienast uploaded patch set 1 11/05/19, 13:55

  2. Andreas Kienast uploaded patch set 2 11/05/19, 13:57

  3. TYPO3com voted on patch set 1 V +1 11/05/19, 14:07 Completed build in 11m 36s on Tue, 5 Nov, 02:07 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38009

  4. TYPO3com voted on patch set 2 V +1 11/05/19, 14:10 Completed build in 12m 49s on Tue, 5 Nov, 02:10 PM Test Summary: 48123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38010

  5. Benni Mack voted on patch set 2 CR +1 11/07/19, 09:08

  6. Johannes Schlier voted on patch set 2 V +1 CR +1 11/07/19, 10:47

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/07/19, 11:42

  8. Benni Mack merged patch set 3 11/07/19, 11:42