Review main Merged

62198[DOCS] Update Context API usage example

Tymoteusz Motylewski CR +2 V +2 Easy +10 −5 updated 12/27/19, 22:39

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Tymoteusz Motylewski uploaded patch set 1 11/05/19, 16:07

  2. TYPO3com voted on patch set 1 V +1 11/05/19, 16:19 Completed build in 11m 49s on Tue, 5 Nov, 04:19 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38015

  3. Alexander Schnitzler commented on patch set 1 CR +1 11/07/19, 13:33

    Deprecation-85389-VariousPublicPropertiesInFavorOfContextAPI.rst:41

    We could also make this a php block instead. Without having it rendered, I think it might look better (more connected).
  4. Benni Mack commented on patch set 1 CR -1 11/07/19, 21:00

    also: missing issue number

    Deprecation-85389-VariousPublicPropertiesInFavorOfContextAPI.rst:41 Reply Unresolved

    ContextContext::class is wrong.
  5. Benni Mack commented on patch set 2 12/27/19, 21:00

    Published edit on patch set 1.
  6. Benni Mack updated the commit message in patch set 3 12/27/19, 21:00

  7. Oliver Hader voted on patch set 3 CR +1 12/27/19, 21:22

  8. TYPO3com voted on patch set 3 V +1 12/27/19, 21:47 Completed build in 23m 26s on Fri, 27 Dec, 09:47 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39619

  9. Benni Mack voted on patch set 3 V +1 CR +1 12/27/19, 21:48

  10. TYPO3com voted on patch set 2 V +1 12/27/19, 21:54 Completed build in 29m 59s on Fri, 27 Dec, 09:54 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39618

  11. Markus Klein voted on patch set 3 V +1 CR +1 12/27/19, 22:38

  12. Benni Mack voted on patch set 3 V +2 CR +2 12/27/19, 22:38

  13. Benni Mack merged patch set 4 12/27/19, 22:39