62199[TASK] Make info messages of InputSlugElement translatable
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 912
-
Georg Ringer uploaded patch set 1 11/05/19, 20:50
-
Georg Ringer commented on patch set 1 11/05/19, 20:50
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 11/05/19, 21:00 Completed build in 10m 20s on Tue, 5 Nov, 09:00 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38023
-
Oli Bartsch commented on patch set 1 V -1 11/06/19, 05:55
InputSlugElement.php:160UnresolvedPlease treat the complete message with htmlspecialchars. To avoid double encoding you should remove it for the $baseUrl above at the variable declaration. same applies for the next line.locallang_core.xlf:913UnresolvedI‘m really unsure if we should introduce such terms. Maybe we should make this more serious. Suggestion: „Unfortunately this is already taken, ...“ -
Sebastian Müller commented on patch set 1 11/06/19, 07:41
Not sure if this will have the outcome I wanted to archive. I want to publish an comment.locallang_core.xlf:907UnresolvedWhen working in the backend with pages and its slugs I found it kind of strange that the page will look like. Maybe something like "Congrats, the url of this page will be %s" or something like that. -
Benni Mack uploaded patch set 2 02/14/20, 11:00
-
Benni Mack uploaded patch set 3 02/14/20, 11:02
-
Benni Mack voted on patch set 3 V +1 CR +1 02/14/20, 11:02
-
TYPO3com voted on patch set 2 V +1 02/14/20, 11:14 Completed build in 14m 39s on Fri, 14 Feb, 11:14 AM Test Summary: 71244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-62
-
TYPO3com voted on patch set 3 V +1 02/14/20, 11:27 Completed build in 21m 45s on Fri, 14 Feb, 11:27 AM Test Summary: 71244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-64
-
Andreas Kienast voted on patch set 3 V +2 CR +2 02/14/20, 11:35
-
Andreas Kienast merged patch set 4 02/14/20, 11:35