Review main Merged

62201[FEATURE] Add additionalAttributes to formDefinitions renderingOptions

Tomita Militaru CR +2 V +2 Easy +32 −0 updated 02/21/20, 08:54

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Björn Jacob +1
    • Henning Liebe +1
    • Felix P. +1
    • Christian Eßl +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Susi Moog +2
    • Björn Jacob +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Tomita Militaru uploaded patch set 1 11/05/19, 22:38

  2. TYPO3com voted on patch set 1 V +1 11/05/19, 22:48 Completed build in 10m 00s on Tue, 5 Nov, 10:48 PM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38026

  3. Simon Gilli commented on patch set 1 11/07/19, 21:33

    Feature-89551-AddAdditionalAttributesToFormDefinitionsRenderingOptions.rst:28

    Why must? A option `can` be set imho
  4. Tomita Militaru rebased onto patch set 2 11/07/19, 22:36

  5. Tomita Militaru commented on patch set 2 11/07/19, 22:37

    Done

    Feature-89551-AddAdditionalAttributesToFormDefinitionsRenderingOptions.rst:28 Reply

    Done
  6. Tomita Militaru uploaded patch set 3 11/07/19, 22:39

  7. TYPO3com voted on patch set 2 V -1 11/07/19, 22:46 Completed build in 10m 25s on Thu, 7 Nov, 10:46 PM Test Summary: 48070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38090

  8. TYPO3com voted on patch set 3 V -1 11/07/19, 22:49 Completed build in 09m 52s on Thu, 7 Nov, 10:49 PM Test Summary: 45963 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38091

  9. Ralf Zimmermann uploaded patch set 4 11/24/19, 12:06

  10. TYPO3com voted on patch set 4 V +1 11/24/19, 12:13 Completed build in 06m 57s on Sun, 24 Nov, 12:13 PM Test Summary: 48160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38798

  11. Tobi Kretschmann voted on patch set 4 CR +1 11/27/19, 08:30

  12. Henning Liebe voted on patch set 4 CR +1 01/14/20, 11:49

  13. Felix P. voted on patch set 4 CR +1 01/14/20, 12:29

  14. Sascha Rademacher voted on patch set 4 CR +1 01/14/20, 13:24

  15. Steffen Frese voted on patch set 4 CR +1 01/17/20, 05:15

  16. Christian Eßl voted on patch set 4 V +1 CR +1 02/20/20, 20:41

  17. Björn Jacob voted on patch set 4 V +1 CR +1 02/20/20, 23:52

  18. Susi Moog voted on patch set 4 V +2 CR +2 02/21/20, 08:54

  19. Susi Moog merged patch set 5 02/21/20, 08:54