62203[TASK] Update doctrine/dbal to 2.10.0
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Hader +1
- Benni Mack +1
Issues 1
Files 2
Review log 1619
-
Manuel Selbach uploaded patch set 1 11/06/19, 10:50
-
TYPO3com voted on patch set 1 V +1 11/06/19, 11:15 Completed build in 19m 01s on Wed, 6 Nov, 11:15 AM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38037
-
Alexander Schnitzler commented on patch set 1 11/07/19, 13:34
Does it solve bugs in TYPO3 as well? Then we could mark them resolves as well with this update. -
Andreas Kienast commented on patch set 1 CR -1 11/07/19, 16:14
The changelog says: The usage of the getHost(), getPort(), getUsername() and getPassword() methods of the Connection class has been deprecated. AFAICS this is used in EnvironmentController::getDatabaseConnectionInformation(). -
Andreas Kienast uploaded patch set 2 11/07/19, 16:19
-
TYPO3com voted on patch set 2 V -1 11/07/19, 16:37 Completed build in 16m 32s on Thu, 7 Nov, 04:37 PM Test Summary: 15 of 48506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38083
-
TYPO3com voted on patch set 2 V +1 11/07/19, 21:04 Completed build in 4h 59m 56s on Thu, 7 Nov, 09:04 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38083
-
Oliver Hader voted on patch set 2 CR +1 11/07/19, 21:55
-
Oli Bartsch voted on patch set 2 CR +1 11/08/19, 07:54
-
Benni Mack commented on patch set 2 V +1 CR +1 11/08/19, 08:19
I would support to also backport this change to v9. This means: TYPO3 v9.5.12 would ship doctrine/dbal 2.10.0 (which adds better support for MySQL 8) -
Benni Mack updated the commit message in patch set 3 11/08/19, 08:19
-
Benni Mack voted on patch set 3 V +1 CR +1 11/08/19, 08:19
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/08/19, 08:20
-
Andreas Kienast voted on patch set 3 V +2 CR +2 11/08/19, 08:26
-
Andreas Kienast merged patch set 4 11/08/19, 08:26
-
Oliver Hader voted on patch set 4 V +1 CR +1 11/08/19, 10:52
-
Oliver Hader commented on patch set 4 11/08/19, 10:57
`Type::* constants are deprecated.` -
Oliver Hader commented on patch set 4 11/08/19, 10:58
> Patch Set 4: > > `Type::* constants are deprecated.` Still being used in TYPO3 core... -
Oliver Hader commented on patch set 4 11/08/19, 11:20
→ follow-up at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62249