Review main Merged

62203[TASK] Update doctrine/dbal to 2.10.0

Manuel Selbach CR +2 V +2 Normal +56 −46 updated 11/08/19, 11:20

Commit message

With this change the new release of doctrine/dbal will be applied,
which will solve different bugfixes and introduce some new features.

For further information:

https://github.com/doctrine/dbal/releases/tag/v2.10.0

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • Benni Mack +1

Issues 1

Files 2

Review log 1619

  1. Manuel Selbach uploaded patch set 1 11/06/19, 10:50

  2. TYPO3com voted on patch set 1 V +1 11/06/19, 11:15 Completed build in 19m 01s on Wed, 6 Nov, 11:15 AM Test Summary: 48131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38037

  3. Alexander Schnitzler commented on patch set 1 11/07/19, 13:34

    Does it solve bugs in TYPO3 as well? Then we could mark them resolves as well with this update.
  4. Andreas Kienast commented on patch set 1 CR -1 11/07/19, 16:14

    The changelog says: The usage of the getHost(), getPort(), getUsername() and getPassword() methods of the Connection class has been deprecated. AFAICS this is used in EnvironmentController::getDatabaseConnectionInformation().
  5. Andreas Kienast uploaded patch set 2 11/07/19, 16:19

  6. TYPO3com voted on patch set 2 V -1 11/07/19, 16:37 Completed build in 16m 32s on Thu, 7 Nov, 04:37 PM Test Summary: 15 of 48506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38083

  7. TYPO3com voted on patch set 2 V +1 11/07/19, 21:04 Completed build in 4h 59m 56s on Thu, 7 Nov, 09:04 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38083

  8. Oliver Hader voted on patch set 2 CR +1 11/07/19, 21:55

  9. Oli Bartsch voted on patch set 2 CR +1 11/08/19, 07:54

  10. Benni Mack commented on patch set 2 V +1 CR +1 11/08/19, 08:19

    I would support to also backport this change to v9. This means: TYPO3 v9.5.12 would ship doctrine/dbal 2.10.0 (which adds better support for MySQL 8)
  11. Benni Mack updated the commit message in patch set 3 11/08/19, 08:19

  12. Benni Mack voted on patch set 3 V +1 CR +1 11/08/19, 08:19

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 11/08/19, 08:20

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 11/08/19, 08:26

  15. Andreas Kienast merged patch set 4 11/08/19, 08:26

  16. Oliver Hader voted on patch set 4 V +1 CR +1 11/08/19, 10:52

  17. Oliver Hader commented on patch set 4 11/08/19, 10:57

    `Type::* constants are deprecated.`
  18. Oliver Hader commented on patch set 4 11/08/19, 10:58

    > Patch Set 4: > > `Type::* constants are deprecated.` Still being used in TYPO3 core...
  19. Oliver Hader commented on patch set 4 11/08/19, 11:20