Review 9.5 Merged

62219[BUGFIX] Prevent indexing of XML sitemaps by search engines

Richard Haeser CR +2 V +2 Easy +15 −3 updated 11/09/19, 06:57

Commit message

The content of a XML sitemap should not be listed on search engine result
pages. This patch adds the HTTP header "X-Robots-Tag:noindex" to the
XML sitemaps.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Richard Haeser commented on patch set 1 11/08/19, 22:42

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapIndexTest.php * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php
  2. TYPO3com voted on patch set 1 V -1 11/08/19, 22:42 Completed build in 12s on Fri, 8 Nov, 10:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1465

  3. Richard Haeser uploaded patch set 2 11/09/19, 06:47

  4. Richard Haeser commented on patch set 2 11/09/19, 06:47

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 11/09/19, 06:56 Completed build in 08m 54s on Sat, 9 Nov, 06:56 AM Test Summary: 50848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1466

  6. Richard Haeser voted on patch set 2 V +2 CR +2 11/09/19, 06:57

  7. Richard Haeser merged patch set 3 11/09/19, 06:57