Review 9.5 Merged

62221[BUGFIX] Respect cacheHash excludedParameters in TSFE::reqCHash()

Benni Mack CR +2 V +2 Normal +91 −0 updated 11/09/19, 09:06

Commit message

* Requests with a parameter from "excludedParameters" settings
  will not raise a cHash comparison error
* Requests with configured enhancers will not raise the
  "Page ID is missing" error when used with additional parameters

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack commented on patch set 1 11/09/19, 08:42

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php
  2. TYPO3com voted on patch set 1 V -1 11/09/19, 08:45 Completed build in 46s on Sat, 9 Nov, 08:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1470

  3. Benni Mack uploaded patch set 2 11/09/19, 08:47

  4. Benni Mack commented on patch set 2 11/09/19, 08:49

    This change is ready for review.
  5. Susi Moog voted on patch set 2 V +1 CR +1 11/09/19, 08:57

  6. TYPO3com voted on patch set 2 V +1 11/09/19, 09:00 Completed build in 12m 42s on Sat, 9 Nov, 09:00 AM Test Summary: 50876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1471

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/09/19, 09:06

  8. Benni Mack merged patch set 3 11/09/19, 09:06