Review 9.5 Merged

62230[BUGFIX] Log invalid hash generation in FAL Indexer

Benni Mack CR +2 V +2 Normal +75 −30 updated 11/09/19, 16:25

Commit message

The FAL Indexer uses the driver to get a hash for a file. In certain
circumstances (and with 3rd party drivers) the hash generated might be
null or invalid. In that case the ResourceStorage now throws an
exception to alert the developer to the wrong return value. At the same
time the Indexer catches and logs the exception to not interrupt the
whole indexing flow because of it.

For more information, please take a look at the ticket.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 35

  1. Benni Mack commented on patch set 1 11/09/19, 15:51

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/09/19, 16:02 Completed build in 10m 51s on Sat, 9 Nov, 04:02 PM Test Summary: 40440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1489

  3. TYPO3com voted on patch set 1 V +1 11/09/19, 16:10 Completed build in 29m 50s on Sat, 9 Nov, 04:10 PM Test Summary: 50921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1489

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/09/19, 16:25

  5. Benni Mack merged patch set 2 11/09/19, 16:25