Review 9.5 Merged

62231[BUGFIX] Set default controller name in ExtbasePluginEnhancer

Benni Mack CR +2 V +2 Normal +102 −7 updated 11/09/19, 16:35

Commit message

The `defaultController` setting is only applied if both `action` and
`controller` parameters are empty. In Extbase context it happens that
only `action` is defined, but `controller` is empty (since linking to
the very same controller, just changing the action).

The behavior now is the following:
* set `action` and `controller` parameters to default if not given
* set `controller` parameter to default if not given

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 11/09/19, 16:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/09/19, 16:32 Completed build in 10m 30s on Sat, 9 Nov, 04:32 PM Test Summary: 50960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1491

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/09/19, 16:35

  4. Benni Mack merged patch set 2 11/09/19, 16:35