Review main Merged

62234[BUGFIX] Make GifBuilder calculation of filename hash faster

Benni Mack CR +2 V +2 Easy +15 −2 updated 03/19/22, 14:05

Commit message

The GifBuilder calculation does not need all of setup
to calculate the values for the filename.

Therefore, only the relevant parameters are used, making
the shortMD5 call faster, according to the ticket author.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Benni Mack uploaded patch set 1 11/06/19, 22:13

  2. TYPO3com voted on patch set 1 V +1 11/06/19, 22:22 Completed build in 09m 49s on Wed, 6 Nov, 10:22 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38052

  3. Benni Mack uploaded patch set 2 11/09/19, 12:06

  4. TYPO3com voted on patch set 2 V -1 11/09/19, 12:14 Completed build in 07m 47s on Sat, 9 Nov, 12:14 PM Test Summary: 820 of 48545 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38162

  5. Susi Moog uploaded patch set 3 11/09/19, 15:07

  6. Susi Moog commented on patch set 3 CR +1 11/09/19, 15:08

    no tests, as the whole gifbuilder needs a rewrite before any sensible testing is possible.
  7. Susi Moog voted on patch set 3 V +1 11/09/19, 15:08

  8. TYPO3com voted on patch set 3 V -1 11/09/19, 15:17 Completed build in 10m 03s on Sat, 9 Nov, 03:17 PM Test Summary: 48247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38192

  9. TYPO3com voted on patch set 3 V +1 11/09/19, 15:36 Completed build in 38m 44s on Sat, 9 Nov, 03:36 PM Test Summary: 48247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38192

  10. Guido Schmechel commented on patch set 3 CR +1 11/09/19, 15:39

    9.5 is not set because it comes to rebuilding the images. Is that correct?
  11. Andreas Kienast voted on patch set 3 V +2 CR +2 11/09/19, 17:00

  12. Andreas Kienast merged patch set 4 11/09/19, 17:00

  13. Simon Schaufelberger commented on patch set 4 03/19/22, 14:05

    This causes wrong images when the array keys are the same with different values like in the example https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Gifbuilder/Examples.html#creating-semi-transparent-boxes-with-transparent-text (just different background color)