62242[TASK] Rework Linkvalidator report
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 8
- typo3/sysext/linkvalidator/Classes/Controller/LinkvalidatorReportController.php1new+267 −0
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+55 −0
- typo3/sysext/linkvalidator/Classes/View/Paginate.php1new+87 −0
- typo3/sysext/linkvalidator/Resources/Private/Language/locallang_module_linkvalidator.xlfnew+21 −0
- typo3/sysext/linkvalidator/Resources/Private/Layouts/LinkvalidatorReport.htmlnew+5 −0
- typo3/sysext/linkvalidator/Resources/Private/Templates/Standard/Report.htmlnew+144 −0
- typo3/sysext/linkvalidator/Resources/Public/Icons/Linkvalidator.svgnew+1 −0
- typo3/sysext/linkvalidator/ext_tables.php+15 −1
Review log 2533
Show 68 earlier messages
-
Sybille Peters uploaded patch set 1 11/07/19, 16:18
-
TYPO3com voted on patch set 1 V -1 11/07/19, 16:21 Completed build in 29s on Thu, 7 Nov, 04:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38082
-
Alexander Schnitzler commented on patch set 1 11/07/19, 17:23
-
Georg Ringer commented on patch set 1 11/07/19, 20:13
LinkvalidatorReportController.php:190Unresolvedthis belongs to fluid -
Sybille Peters commented on patch set 1 11/08/19, 12:53
Thanks, guys. This is a really, really early WIP. I reactivated some 1 year old code. Needs more work ... @Alex I saw the Paginate and I definitely would like to use that. -
Benni Mack uploaded patch set 2 11/09/19, 14:47
-
TYPO3com voted on patch set 2 V -1 11/09/19, 14:55 Completed build in 07m 45s on Sat, 9 Nov, 02:55 PM Test Summary: 2 of 48602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38190
-
Sybille Peters uploaded patch set 3 11/09/19, 15:12
-
TYPO3com voted on patch set 3 V -1 11/09/19, 15:22 Completed build in 09m 05s on Sat, 9 Nov, 03:22 PM Test Summary: 2 of 48606 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38194
-
TYPO3com commented on patch set 3 11/09/19, 15:35 Completed build in 31m 26s on Sat, 9 Nov, 03:35 PM Test Summary: 2 of 48606 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38194
-
Sybille Peters uploaded patch set 4 11/09/19, 17:54
-
TYPO3com voted on patch set 4 V -1 11/09/19, 18:03 Completed build in 08m 56s on Sat, 9 Nov, 06:03 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38221
-
Sybille Peters wrote 11/14/19, 03:59
Topic set to linkvalidator -
Sybille Peters marked it work in progress 11/17/19, 08:33
-
Sybille Peters uploaded patch set 5 01/07/20, 17:14
-
TYPO3com voted on patch set 5 V -1 01/07/20, 17:21 Completed build in 07m 27s on Tue, 7 Jan, 05:21 PM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39745
-
Sybille Peters uploaded patch set 6 01/08/20, 15:45
-
TYPO3com voted on patch set 6 V -1 01/08/20, 15:57 Completed build in 12m 08s on Wed, 8 Jan, 03:57 PM Test Summary: 12 of 69365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39757
-
Benni Mack commented on patch set 6 03/07/20, 11:06
Hey Sybille, I think we're on the brink of having most changes already in Core now. So this change could only be the "migrate to standalone module" change. Or would you want to modify the logic as well? I would strongly recommend removing the logic from the Info module completely, and only have the custom module instead. -
Benni Mack commented on patch set 6 03/07/20, 11:07
Should we continue with this change like that, Sybille? Or start over again? btw... where did you get the icon? Was it copied from somewhere else? -
Sybille Peters commented on patch set 6 03/10/20, 16:21
Benni: I got the icon when I originally started working on linkvalidator from Mathias Schreiber and I think it was created by Benjamin Kott. What to do next? This review is now in conflict with the changes you made recently. I have not looked at them yet. It is ok with me if someone wants to start over and reuse some of my work or update this patch. I don't have time for this right now, but would be very happy if we can continue. btw. what about feature-freeze? Or is this a rework that can be done in v10? My original idea was to change the "Linkvalidator Report" GUI to a semi-hierachical list. Example: information about page | -> information about content element & edit button | -> broken link 1 -> broken link 2 A lot of the displayed information in the "linkvalidator report" is duplicate if you have for example several broken links in one record or on one page. e.g. the rootline of the page, the content element header etc. This might look a little like the "Access" module, but different. I also had plans to restrict the number of links displayed (max per page) and use paginate (see Paginate interface by Alex). I did not get to finish this and wasn't really satisfied with it (yet). And it's probably not a bad idea to do this in 2 steps: 1.refactor. 2. Then create new GUI. -
Benni Mack uploaded patch set 7 03/18/20, 08:50
-
Benni Mack commented on patch set 7 03/18/20, 08:52
Nice! Just rebased this patch. I suggest we take the "semi-hierarchical table" concept into the current module, and extract the "custom BE module" into a separate patch. -
TYPO3com voted on patch set 7 V -1 03/18/20, 09:02 Completed build in 11m 50s on Wed, 18 Mar, 09:02 AM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1413
-
Sybille Peters commented on patch set 7 03/18/20, 14:54
> Patch Set 7: > > Nice! Just rebased this patch. I suggest we take the "semi-hierarchical table" concept into the current module, and extract the "custom BE module" into a separate patch. I am not sure if I understand this correctly (yet). Do you mean "custom BE module" = "own BE module" (instead of in Info module). Should the goal be to have (eventually) the own module instead of the info module? -
Benni Mack commented on patch set 7 09/04/20, 12:14
> Patch Set 7: > > > Patch Set 7: > > > > Nice! Just rebased this patch. I suggest we take the "semi-hierarchical table" concept into the current module, and extract the "custom BE module" into a separate patch. > > I am not sure if I understand this correctly (yet). Do you mean "custom BE module" = "own BE module" (instead of in Info module). yes. > Should the goal be to have (eventually) the own module instead of the info module? I would say so. You can do more than just get an "Information" for broken links now. right? -
Sybille Peters commented on patch set 7 10/15/20, 11:32
> Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: > > > > > > Nice! Just rebased this patch. I suggest we take the "semi-hierarchical table" concept into the current module, and extract the "custom BE module" into a separate patch. > > > > I am not sure if I understand this correctly (yet). Do you mean "custom BE module" = "own BE module" (instead of in Info module). > yes. > > > Should the goal be to have (eventually) the own module instead of the info module? > I would say so. You can do more than just get an "Information" for broken links now. right? I will abandon this now. I am not sure how to proceed. -
Sybille Peters abandoned the change 10/15/20, 19:10
-
Sybille Peters restored the change 11/03/20, 16:27
-
Sybille Peters marked it work in progress 11/03/20, 16:27
-
Sybille Peters wrote 11/03/20, 16:27
Topic linkvalidator removed -
Sybille Peters wrote 11/03/20, 16:27
Topic set to Linkvalidator -
Sybille Peters abandoned the change 11/04/21, 17:11
This must be thought through first from a usability perspective
Paginate.php:18Unresolved