Review main Merged

62243[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext

Benni Mack CR +2 V +2 Easy +4 −2 updated 11/08/19, 08:10

Commit message

The applicationContext tests were only checking
the string "applicationContext" and not the actual
object that was injected by the provider.

The change adapts the tests to make them actually
useful.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Benni Mack uploaded patch set 1 11/07/19, 21:19

  2. Benni Mack commented on patch set 1 CR -1 11/07/19, 21:19

    Issue number missing
  3. Benni Mack updated the commit message in patch set 2 11/07/19, 21:20

  4. TYPO3com voted on patch set 1 V -1 11/07/19, 21:28 Completed build in 09m 41s on Thu, 7 Nov, 09:28 PM Test Summary: 30 of 46256 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38085

  5. TYPO3com voted on patch set 2 V -1 11/07/19, 22:23 Completed build in 1h 03m 16s on Thu, 7 Nov, 10:23 PM Test Summary: 212 of 36250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38086

  6. Frank Nägler uploaded patch set 3 11/08/19, 07:41

  7. Frank Nägler voted on patch set 3 V +1 CR +1 11/08/19, 07:43

  8. TYPO3com voted on patch set 3 V -1 11/08/19, 07:51 Completed build in 09m 55s on Fri, 8 Nov, 07:51 AM Test Summary: 428 of 37560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38094

  9. TYPO3com voted on patch set 3 V +1 11/08/19, 08:07 Completed build in 35m 56s on Fri, 8 Nov, 08:07 AM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38094

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/08/19, 08:10

  11. Benni Mack merged patch set 4 11/08/19, 08:10