Review 9.5 Merged

62245[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext

Benni Mack CR +2 V +2 Easy +4 −2 updated 11/08/19, 08:56

Commit message

The applicationContext tests were only checking
the string "applicationContext" and not the actual
object that was injected by the provider.

The change adapts the tests to make them actually
useful.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack uploaded patch set 1 11/08/19, 08:15

  2. TYPO3com voted on patch set 1 V +1 11/08/19, 08:53 Completed build in 38m 36s on Fri, 8 Nov, 08:53 AM Test Summary: 50836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1453

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/08/19, 08:56

  4. Benni Mack merged patch set 2 11/08/19, 08:56