62246[TASK] Update doctrine/dbal to 2.10.0
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+15 −14
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php+4 −4
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+3 −3
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+4 −4
- composer.json+1 −1
- composer.lock+40 −30
Review log 1319
-
Andreas Kienast uploaded patch set 1 11/08/19, 08:29
-
Oliver Hader commented on patch set 1 11/08/19, 09:04
Was the ChangeLog checked? What does that mean for v9.5? -
TYPO3com voted on patch set 1 V -1 11/08/19, 10:08 Completed build in 1h 08m 21s on Fri, 8 Nov, 10:08 AM Test Summary: 47697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1454
-
TYPO3com voted on patch set 1 V +1 11/08/19, 10:34 Completed build in 2h 43m 32s on Fri, 8 Nov, 10:34 AM Test Summary: 50836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1454
-
Oliver Hader commented on patch set 1 V +1 CR +1 11/08/19, 10:52
ChangeLog concerning 9.5 looks good to me, what do others think? -
Oliver Hader voted on patch set 1 V -1 11/08/19, 10:56
-
Oliver Hader commented on patch set 1 11/08/19, 10:58
`Type::* constants are deprecated.` - still used in core -
Oliver Hader commented on patch set 1 11/08/19, 11:17
On it.. -
Oliver Hader uploaded patch set 2 11/08/19, 11:26
-
Oliver Hader commented on patch set 2 11/08/19, 11:29
Should be fine now. Manuel, could you please have a look again whether I forgot/overlooked something? Thx -
TYPO3com voted on patch set 2 V -1 11/08/19, 11:34 Completed build in 07m 37s on Fri, 8 Nov, 11:34 AM Test Summary: 7 of 44073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1458
-
TYPO3com commented on patch set 2 11/08/19, 11:48 Completed build in 29m 12s on Fri, 8 Nov, 11:48 AM Test Summary: 7 of 45646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1458
-
TYPO3com voted on patch set 2 V +1 11/08/19, 12:43 Completed build in 1h 46m 16s on Fri, 8 Nov, 12:43 PM Test Summary: 50848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1458
-
Manuel Selbach commented on patch set 2 11/08/19, 13:49
> Patch Set 2: > > Should be fine now. Manuel, could you please have a look again whether I forgot/overlooked something? Thx I checked the types. Looks fine! Thanks for finding that. What I saw is, that the doctrine/cache does not get updated, which is the case on the patch on master. Is there a reason why that required package does not get updated here? -
Manuel Selbach commented on patch set 2 11/12/19, 18:01
> Patch Set 2: > > > Patch Set 2: > > > > Should be fine now. Manuel, could you please have a look again whether I forgot/overlooked something? Thx > > I checked the types. Looks fine! Thanks for finding that. > > What I saw is, that the doctrine/cache does not get updated, which is the case on the patch on master. Is there a reason why that required package does not get updated here? Furthermore I would also suggest to update the minimum requirement version to ^2.10 with introducing the types from Doctrine\DBAL\Types\Types. Thanks to Susanne Moog for finding that. -
Manuel Selbach uploaded patch set 3 11/12/19, 18:22
-
TYPO3com voted on patch set 3 V +1 11/12/19, 18:32 Completed build in 10m 02s on Tue, 12 Nov, 06:32 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1511
-
Oliver Hader voted on patch set 3 V +2 CR +2 11/18/19, 11:37
-
Oliver Hader merged patch set 4 11/18/19, 11:37