Review main Merged

62247[TASK] Use Environment API to fetch application context

Benni Mack CR +2 V +2 Normal +107 −103 updated 11/13/19, 05:01

Commit message

The application context is stored in the Environment class since TYPO3 v9,
which is the correct place instead of GeneralUtility::getApplicationContext().

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 610

  1. Benni Mack uploaded patch set 1 11/08/19, 08:40

  2. TYPO3com voted on patch set 1 V -1 11/08/19, 10:15 Completed build in 1h 15m 35s on Fri, 8 Nov, 10:15 AM Test Summary: 1 of 48506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38100

  3. TYPO3com voted on patch set 1 V +1 11/08/19, 10:29 Completed build in 2h 45m 18s on Fri, 8 Nov, 10:29 AM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38100

  4. Benni Mack updated the commit message in patch set 2 11/10/19, 20:40

  5. TYPO3com voted on patch set 2 V +1 11/10/19, 20:47 Completed build in 07m 15s on Sun, 10 Nov, 08:47 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38249

  6. Benni Mack uploaded patch set 3 11/10/19, 20:54

  7. TYPO3com voted on patch set 3 V +1 11/10/19, 21:01 Completed build in 07m 40s on Sun, 10 Nov, 09:01 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38250

  8. Georg Ringer voted on patch set 3 V +1 CR +1 11/12/19, 19:22

  9. Susi Moog voted on patch set 3 V +2 CR +2 11/13/19, 04:50

  10. Susi Moog merged patch set 4 11/13/19, 05:01