Review main Merged

62249[TASK] Avoid using deprecated Doctrine types

Oliver Hader CR +2 V +2 Easy +19 −18 updated 11/12/19, 17:53

Commit message

Issue #89592 upgraded Doctrine to v2.10.0 - usages of deprecated
`TYPE::*` constants have not been adjusted (see doctrine/dbal
changelog https://github.com/doctrine/dbal/releases/tag/v2.10.0).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Manuel Selbach +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1217

  1. Oliver Hader uploaded patch set 1 11/08/19, 11:10

  2. Oliver Hader updated the commit message in patch set 2 11/08/19, 11:11

  3. TYPO3com voted on patch set 1 V -1 11/08/19, 11:17 Completed build in 07m 40s on Fri, 8 Nov, 11:17 AM Test Summary: 42385 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38104

  4. TYPO3com voted on patch set 2 V -1 11/08/19, 11:18 Completed build in 06m 44s on Fri, 8 Nov, 11:18 AM Test Summary: 3 of 41547 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38105

  5. Andreas Kienast commented on patch set 2 11/08/19, 11:21

    TableBuilder.php:333

    Shouldn't this be Types::DATETIME_MUTABLE?
  6. Oliver Hader commented on patch set 2 11/08/19, 11:23

    TableBuilder.php:333 Reply

    Ack
  7. Oliver Hader uploaded patch set 3 11/08/19, 11:24

  8. Oliver Hader commented on patch set 3 11/08/19, 11:24

    Bamboo seems to have some hick-ups...
  9. TYPO3com commented on patch set 2 11/08/19, 11:25 Completed build in 20m 18s on Fri, 8 Nov, 11:25 AM Test Summary: 6 of 43405 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38105

  10. TYPO3com voted on patch set 3 V -1 11/08/19, 11:31 Completed build in 06m 57s on Fri, 8 Nov, 11:31 AM Test Summary: 42374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38107

  11. TYPO3com voted on patch set 3 V +1 11/08/19, 12:39 Completed build in 1h 53m 16s on Fri, 8 Nov, 12:39 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38107

  12. Manuel Selbach voted on patch set 3 CR +1 11/08/19, 13:58

  13. Manuel Selbach voted on patch set 3 V +1 11/08/19, 13:59

  14. Oliver Hader voted on patch set 3 V +2 CR +2 11/08/19, 14:49

  15. Oliver Hader merged patch set 4 11/08/19, 14:49

  16. Susi Moog commented on patch set 4 11/09/19, 09:51

    we need to update doctrine/dbal minimum requirement to ^2.10 else this fails.
  17. Manuel Selbach commented on patch set 4 11/12/19, 17:53

    > Patch Set 4: > > we need to update doctrine/dbal minimum requirement to ^2.10 else this fails. You're right, thanks for catching that. I've created the following ticket to update the requirement: https://forge.typo3.org/issues/89657