Review main Merged

62255[TASK] Add additional workspaces tests covering enable fields

Oliver Hader CR +2 V +2 Normal +76 −34 updated 11/09/19, 09:03

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1220

  1. Oliver Hader uploaded patch set 1 11/08/19, 15:23

  2. TYPO3com voted on patch set 1 V -1 11/08/19, 15:24 Completed build in 18s on Fri, 8 Nov, 03:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38125

  3. Oliver Hader uploaded patch set 2 11/08/19, 15:26

  4. TYPO3com voted on patch set 2 V -1 11/08/19, 15:27 Completed build in 13s on Fri, 8 Nov, 03:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38126

  5. Oliver Hader uploaded patch set 3 11/08/19, 15:29

  6. TYPO3com voted on patch set 3 V -1 11/08/19, 15:37 Completed build in 07m 50s on Fri, 8 Nov, 03:37 PM Test Summary: 3 of 48512 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38127

  7. Oliver Hader uploaded patch set 4 11/08/19, 16:39

  8. Oliver Hader updated the commit message in patch set 5 11/08/19, 16:40

  9. Oliver Hader voted on patch set 5 CR -1 11/08/19, 16:40

  10. TYPO3com voted on patch set 4 V -1 11/08/19, 16:48 Completed build in 08m 47s on Fri, 8 Nov, 04:48 PM Test Summary: 48150 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38128

  11. TYPO3com voted on patch set 5 V -1 11/08/19, 16:49 Completed build in 09m 01s on Fri, 8 Nov, 04:49 PM Test Summary: 48148 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38129

  12. TYPO3com commented on patch set 5 11/08/19, 17:30 Completed build in 59m 18s on Fri, 8 Nov, 05:30 PM Test Summary: 48148 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38129

  13. Oliver Hader uploaded patch set 6 11/08/19, 17:36

  14. Oliver Hader uploaded patch set 7 11/08/19, 17:41

  15. TYPO3com voted on patch set 6 V -1 11/08/19, 17:42 Completed build in 06m 32s on Fri, 8 Nov, 05:42 PM Test Summary: 3 of 46461 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38131

  16. TYPO3com voted on patch set 7 V +1 11/08/19, 17:56 Completed build in 11m 48s on Fri, 8 Nov, 05:56 PM Test Summary: 48150 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38133

  17. Oliver Hader commented on patch set 7 11/09/19, 09:02

    localizeContentWHideAtCopy.csv:14

    Placeholder value for hidden is wrong - but that is expected for this test case - shall be fixed in separate bugfix
  18. Benni Mack commented on patch set 7 V +1 CR +1 11/09/19, 09:03

    localizeContentWHideAtCopy.csv:14 Reply Unresolved

    NICE!
  19. Oliver Hader voted on patch set 7 V +2 CR +2 11/09/19, 09:03

  20. Oliver Hader merged patch set 8 11/09/19, 09:03