Review main Merged

62265[BUGFIX] Add fallback identifier to IRRE fields

Susi Moog CR +2 V +2 Easy +2 −1 updated 11/09/19, 21:01

Commit message

In case of IRRE in site context not the full form engine variables
are available - therefor a fallback has been implemented.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Susi Moog uploaded patch set 1 11/09/19, 19:53

  2. TYPO3com voted on patch set 1 V -1 11/09/19, 19:54 Completed build in 14s on Sat, 9 Nov, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38228

  3. Susi Moog uploaded patch set 2 11/09/19, 19:55

  4. TYPO3com voted on patch set 2 V -1 11/09/19, 20:03 Completed build in 07m 48s on Sat, 9 Nov, 08:03 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38229

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 11/09/19, 20:16

  6. TYPO3com voted on patch set 2 V +1 11/09/19, 20:18 Completed build in 30m 27s on Sat, 9 Nov, 08:18 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38229

  7. Oli Bartsch commented on patch set 2 V +1 CR +1 11/09/19, 20:29

    Should we add #89588 as related since this introduced the bug?
  8. Benni Mack voted on patch set 2 V +2 CR +2 11/09/19, 21:01

  9. Benni Mack merged patch set 3 11/09/19, 21:01