Review main Merged

62266[TASK] Add examples to ext:backend ViewHelpers

Oli Bartsch CR +2 V +2 Normal +70 −2 updated 11/17/19, 09:12

Commit message

Following ViewHelpers now also feature proper examples:
* AvatarViewHelper
* ThumbnailViewHelper

As the ViewHelpers are not declared as `@internal` custom extension
can use them for e.g. backend modules. Therefore they now contain
examples about the usage.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Daniel Siepmann +1
    • Susi Moog +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 11/09/19, 20:22

  2. TYPO3com voted on patch set 1 V -1 11/09/19, 20:30 Completed build in 07m 50s on Sat, 9 Nov, 08:30 PM Test Summary: 48283 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38231

  3. TYPO3com voted on patch set 1 V +1 11/09/19, 20:39 Completed build in 07m 41s on Sat, 9 Nov, 08:39 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38232

  4. Susi Moog voted on patch set 1 CR +1 11/10/19, 08:26

  5. Georg Ringer voted on patch set 1 V +1 CR +1 11/11/19, 12:51

  6. Daniel Siepmann voted on patch set 1 V +1 CR +1 11/11/19, 13:01

  7. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 11/17/19, 09:12

  8. Tymoteusz Motylewski merged patch set 2 11/17/19, 09:12