62267[TASK] Remove reqCHash functionality for plugins
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Daniel Goerz +1
- Markus Klein +1
- Susi Moog +1
-
Verified V +2 Done
- Frank Nägler +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89868-RemoveReqCHashFunctionalityForPlugins.rstnew+61 −0
- typo3/sysext/extbase/Classes/Mvc/Web/CacheHashEnforcer.phpdeleted+0 −74
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+1 −18
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/CacheHashEnforcerTest.phpdeleted+0 −77
- typo3/sysext/extbase/ext_typoscript_setup.typoscript+0 −2
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+0 −10
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php1+2 −1
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+0 −2
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+4 −31
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+0 −78
- typo3/sysext/frontend/Tests/UnitDeprecated/Controller/TypoScriptFrontendControllerTest.php2new+132 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+10 −0
Review log 2132
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 11/09/19, 21:48
-
TYPO3com voted on patch set 1 V -1 11/09/19, 21:56 Completed build in 08m 00s on Sat, 9 Nov, 09:56 PM Test Summary: 28 of 48643 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38239
-
Benni Mack uploaded patch set 2 11/10/19, 21:03
-
TYPO3com voted on patch set 2 V -1 11/10/19, 21:03 Completed build in 15s on Sun, 10 Nov, 09:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38251
-
Benni Mack uploaded patch set 3 11/10/19, 21:12
-
TYPO3com voted on patch set 3 V +1 11/10/19, 21:20 Completed build in 08m 12s on Sun, 10 Nov, 09:20 PM Test Summary: 48274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38252
-
Benni Mack updated the commit message in patch set 4 11/13/19, 20:26
-
TYPO3com voted on patch set 4 V -1 11/13/19, 20:34 Completed build in 08m 01s on Wed, 13 Nov, 08:34 PM Test Summary: 48053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38349
-
TYPO3com voted on patch set 4 V +1 11/14/19, 11:20 Completed build in 15h 01m 14s on Thu, 14 Nov, 11:20 AM Test Summary: 48298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38349
-
Oliver Hader commented on patch set 4 CR +1 11/18/19, 12:01
General "looks good"TypoScriptFrontendController.php:1729Unresolved@note: I should check test-coverage here again...TypoScriptFrontendControllerTest.php:122UnresolvedWhat happens with 'foo=1'? ;-)TypoScriptFrontendControllerTest.php:128Unresolved`$this->expectException` in this case... anyway, probably we could check the wrapped response objection here instead -
Benni Mack uploaded patch set 5 11/23/19, 14:53
-
TYPO3com voted on patch set 5 V +1 11/23/19, 15:03 Completed build in 07m 14s on Sat, 23 Nov, 03:03 PM Test Summary: 48139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38764
-
Benni Mack uploaded patch set 6 12/06/19, 08:08
-
TYPO3com voted on patch set 6 V -1 12/06/19, 08:16 Completed build in 08m 46s on Fri, 6 Dec, 08:16 AM Test Summary: 2 of 69180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39128
-
TYPO3com voted on patch set 6 V +1 12/06/19, 13:46 Completed build in 5h 47m 02s on Fri, 6 Dec, 01:46 PM Test Summary: 68730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39128
-
Susi Moog commented on patch set 7 12/06/19, 14:47
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V -1 12/06/19, 14:55 Completed build in 07m 10s on Fri, 6 Dec, 02:55 PM Test Summary: 68697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39171
-
Susi Moog voted on patch set 7 V +1 CR +1 12/06/19, 14:58
-
TYPO3com voted on patch set 7 V +1 12/06/19, 15:00 Completed build in 19m 15s on Fri, 6 Dec, 03:00 PM Test Summary: 68697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39171
-
Mathias Brodala commented on patch set 7 12/06/19, 15:13
It's funny on the first read but in the long term we should elaborate on this. ;-) -
Markus Klein commented on patch set 7 12/06/19, 15:20
rock'n'roll -
Markus Klein voted on patch set 7 CR +1 12/06/19, 15:40
-
Markus Klein commented on patch set 7 12/06/19, 15:41
Reply
, for security reasons. enough elaboration? ;-) -
Mathias Brodala commented on patch set 7 12/06/19, 16:05
Reply Unresolved
Actually yes. -
Mathias Brodala commented on patch set 7 CR -1 12/06/19, 16:05
I'll add the important word. -
Mathias Brodala updated the commit message in patch set 8 12/06/19, 16:06
-
TYPO3com voted on patch set 8 V +1 12/06/19, 16:14 Completed build in 07m 33s on Fri, 6 Dec, 04:14 PM Test Summary: 68697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39184
-
Markus Klein voted on patch set 8 CR +1 12/06/19, 17:05
-
Susi Moog voted on patch set 8 V +1 CR +1 12/06/19, 17:29
-
Daniel Goerz voted on patch set 8 CR +1 12/06/19, 20:04
-
Frank Nägler voted on patch set 8 V +2 CR +2 12/06/19, 20:57
-
Frank Nägler merged patch set 9 12/06/19, 20:58