62269[BUGFIX] Make clear cache error notification translatable
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
-
Verified V +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1013
-
Oli Bartsch uploaded patch set 1 11/10/19, 17:34
-
TYPO3com voted on patch set 1 V +1 11/10/19, 17:42 Completed build in 07m 55s on Sun, 10 Nov, 05:42 PM Test Summary: 48290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38246
-
Oli Bartsch commented on patch set 1 11/10/19, 17:43
This is the followup issue to the post -1 of Frank on https://review.typo3.org/c/Packages/TYPO3.CMS/+/61481. I declared it only for master because the backport https://review.typo3.org/c/Packages/TYPO3.CMS/+/62001 isn't merged yet. So IMO we have the following two possibilities: 1. Add 9.5 as far as the backport was merged. 2. Leave this only for master and just update the backport after this one was merged. Personally I prefer the second option, but it's up to you. -
Oli Bartsch uploaded patch set 2 11/10/19, 18:26
-
TYPO3com voted on patch set 2 V +1 11/10/19, 18:34 Completed build in 07m 40s on Sun, 10 Nov, 06:34 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38247
-
Sybille Peters commented on patch set 2 11/14/19, 09:22
There are more untranslated texts for cache clearing errors in typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/Cache.js: Strictly speaking that is not scope of this patch. Maybe you can decide if you want to add translations for that as well: - "Something went wrong clearing caches" - "Caches cleared Successfully cleared all caches and all available opcode caches." -
Oli Bartsch commented on patch set 2 11/14/19, 15:37
> Patch Set 2: > > There are more untranslated texts for cache clearing errors in typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/Cache.js: > > Strictly speaking that is not scope of this patch. Maybe you can decide if you want to add translations for that as well: > > - "Something went wrong clearing caches" > > - "Caches cleared > Successfully cleared all caches and all available opcode caches." Thanks for the feedback. Sure there are some more places. Please see my first comment about the reason for this patch. I'm open to adjust this but we have first to clarify how we move on with the already merged patch, which introduced these labels, and it's backport. -
Andreas Kienast commented on patch set 2 12/06/19, 15:46
> Patch Set 2: > > There are more untranslated texts for cache clearing errors in typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/Cache.js: Install Tool is not designed to be translatable, yet. -
Andreas Kienast uploaded patch set 3 12/06/19, 15:47
-
Andreas Kienast voted on patch set 3 V +1 CR +1 12/06/19, 15:49
-
TYPO3com voted on patch set 3 V +1 12/06/19, 15:56 Completed build in 07m 30s on Fri, 6 Dec, 03:56 PM Test Summary: 68730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39183
-
Daniel Goerz voted on patch set 3 V +2 CR +2 12/06/19, 17:16
-
Daniel Goerz merged patch set 4 12/06/19, 17:16