Review main Merged

62270[FEATURE] Allow flexible base url for slug fields in FormEngine

Benni Mack CR +2 V +2 Hard +526 −88 updated 04/13/20, 21:14

Commit message

Due to wrong prefixes of TCA type=slug fields for custom records
e.g. in ext:news, a new configuration `prefix` is introduced.

A `userFunc` can be assigned to the new field which then allows to
provide a custom base url based on e.g. the correct detail page.

The default behaviour, which is used for pages, is still applied,
when no custom base url is given.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2238

Show 813 earlier messages
  1. Benni Mack uploaded patch set 1 11/10/19, 22:27

  2. TYPO3com voted on patch set 1 V -1 11/10/19, 22:28 Completed build in 12s on Sun, 10 Nov, 10:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38253

  3. Benni Mack uploaded patch set 2 04/07/20, 20:03

  4. Benni Mack uploaded patch set 3 04/07/20, 20:14

  5. TYPO3com voted on patch set 2 V -1 04/07/20, 20:15 Completed build in 12m 03s on Tue, 7 Apr, 08:15 PM Test Summary: 6 of 73527 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2284

  6. TYPO3com voted on patch set 3 V -1 04/07/20, 20:27 Completed build in 12m 41s on Tue, 7 Apr, 08:27 PM Test Summary: 6 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2285

  7. Josef Glatz commented on patch set 3 04/07/20, 20:54

    Really nice idea! Tested it with an rough example for ext:news column "path_segment" field which works on first test run: 'appearance' => [ 'prefix' => GeorgRinger\News\Utility\Slug::class . '->slugPrefix', ] ------------------------ <?php declare(strict_types = 1); namespace GeorgRinger\News\Utility; class Slug { public function slugPrefix(array $prefix) { return '/pfad/zu/news/dann/wann'; } } Are there some other initial ideas, how to add more meaningful prefix string for e.g. news extension instead of a dummy string prefix (don't get me wrong: just having a dummy prefix is also really a benefit for editors)

    TcaSlug.php:28

    needs to be adjusted
  8. Benni Mack commented on patch set 3 04/07/20, 20:56

    > Are there some other initial ideas, how to add more meaningful prefix string for e.g. news extension instead of a dummy string prefix (don't get me wrong: just having a dummy prefix is also really a benefit for editors) The point is that EXT:news could create a custom prefix for e.g. where the detail view is, depending on the SysFolder etc. That's all up for the custom extensions to set up.
  9. Oli Bartsch uploaded patch set 4 04/08/20, 22:03

  10. Oli Bartsch uploaded patch set 5 04/08/20, 22:04

  11. TYPO3com voted on patch set 4 V -1 04/08/20, 22:17 Completed build in 13m 19s on Wed, 8 Apr, 10:17 PM Test Summary: 6 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2333

  12. TYPO3com voted on patch set 5 V -1 04/08/20, 22:23 Completed build in 15m 23s on Wed, 8 Apr, 10:23 PM Test Summary: 6 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2334

  13. Josef Glatz commented on patch set 5 04/09/20, 09:21

    TcaSlug.php:28 Reply

    Done
  1. Oli Bartsch uploaded patch set 6 04/09/20, 20:09

  2. TYPO3com voted on patch set 6 V -1 04/09/20, 20:19 Completed build in 10m 46s on Thu, 9 Apr, 08:19 PM Test Summary: 6 of 73853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2365

  3. Oli Bartsch uploaded patch set 7 04/13/20, 09:17

  4. Oli Bartsch uploaded patch set 8 04/13/20, 09:21

  5. Benni Mack uploaded patch set 9 04/13/20, 09:34

  6. TYPO3com voted on patch set 7 V -1 04/13/20, 09:35 Completed build in 16m 29s on Mon, 13 Apr, 09:35 AM Test Summary: 6 of 73911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2427

  7. TYPO3com voted on patch set 8 V +1 04/13/20, 09:51 Completed build in 23m 26s on Mon, 13 Apr, 09:51 AM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2429

  8. TYPO3com voted on patch set 9 V +1 04/13/20, 09:55 Completed build in 20m 46s on Mon, 13 Apr, 09:55 AM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2430

  9. Oli Bartsch uploaded patch set 10 04/13/20, 10:44

  10. Oli Bartsch updated the commit message in patch set 11 04/13/20, 10:47

  11. TYPO3com voted on patch set 10 V +1 04/13/20, 11:07 Completed build in 20m 43s on Mon, 13 Apr, 11:07 AM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2434

  12. TYPO3com voted on patch set 11 V +1 04/13/20, 11:16 Completed build in 26m 23s on Mon, 13 Apr, 11:16 AM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2436

  13. Oli Bartsch uploaded patch set 12 04/13/20, 13:04

  14. TYPO3com voted on patch set 12 V -1 04/13/20, 13:47 Completed build in 22m 42s on Mon, 13 Apr, 01:47 PM Test Summary: 1 of 73911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2444

  15. TYPO3com voted on patch set 12 V +1 04/13/20, 14:08 Completed build in 1h 05m 54s on Mon, 13 Apr, 02:08 PM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2444

  16. TYPO3com voted on patch set 12 V -1 04/13/20, 14:14 Completed build in 12m 59s on Mon, 13 Apr, 02:14 PM Test Summary: 1 of 73911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2447

  17. Chris Müller uploaded patch set 13 04/13/20, 14:26

  18. TYPO3com voted on patch set 13 V +1 04/13/20, 14:37 Completed build in 11m 31s on Mon, 13 Apr, 02:37 PM Test Summary: 73427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2449

  19. Georg Ringer voted on patch set 13 V +1 CR +1 04/13/20, 17:08

  20. Benni Mack commented on patch set 14 04/13/20, 20:09

    Published edit on patch set 13.
  21. TYPO3com voted on patch set 14 V +1 04/13/20, 20:19 Completed build in 10m 24s on Mon, 13 Apr, 08:19 PM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2460

  22. Josef Glatz voted on patch set 14 CR +1 04/13/20, 20:24

  23. Benni Mack voted on patch set 14 V +1 CR +1 04/13/20, 21:06

  24. Georg Ringer voted on patch set 14 V +2 CR +2 04/13/20, 21:14

  25. Georg Ringer merged patch set 15 04/13/20, 21:14