Review 9.5 Merged

62277[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/12/19, 12:55

Commit message

This patch adds a cast to the property `$mask` before handing it over to
`IpAnonymizationUtility::anonymizeIp()` as this method requires `$mask`
to be an `int`. This is necessary as when the task was created and saved
in TYPO3 8 it was serialized as `string`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 47

  1. Benni Mack commented on patch set 1 11/12/19, 12:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/12/19, 12:26 Completed build in 10m 35s on Tue, 12 Nov, 12:26 PM Test Summary: 47735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1509

  3. Oliver Klee voted on patch set 1 CR +1 11/12/19, 12:34

  4. TYPO3com commented on patch set 1 11/12/19, 12:45 Completed build in 40m 13s on Tue, 12 Nov, 12:45 PM Test Summary: 50549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1509

  5. TYPO3com voted on patch set 1 V +1 11/12/19, 12:52 Completed build in 1h 17m 10s on Tue, 12 Nov, 12:52 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1509

  6. Benni Mack voted on patch set 1 V +2 CR +2 11/12/19, 12:55

  7. Benni Mack merged patch set 2 11/12/19, 12:55