Review 9.5 Merged

62281[BUGFIX] Respect config.intTarget and extTarget in default ParseFunc

Daniel Goerz CR +2 V +2 Easy +6 −2 updated 11/17/19, 16:08

Commit message

Fluid Styled Content's "lib.parseFunc" always sets the extTarget (target for
external URLs) to the constant, but never considers config.extTarget anymore.

Same goes for the internal target, where target is never set, as
the target parameter is already filled.

The patch adds some minor inline information as well as
the proper values.

In the future, it would make sense to use the same target values
for config.*target (which is for ALL links and not just the ones in parseFunc)
which should be populated by the constants, and not have the constants
interfer into lib.parseFunc anymore.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 38

  1. Daniel Goerz commented on patch set 1 11/17/19, 15:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/17/19, 15:24 Completed build in 09m 21s on Sun, 17 Nov, 03:24 PM Test Summary: 50676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1525

  3. TYPO3com commented on patch set 1 11/17/19, 15:35 Completed build in 09m 12s on Sun, 17 Nov, 03:35 PM Test Summary: 50363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1526

  4. TYPO3com commented on patch set 1 11/17/19, 15:47 Completed build in 08m 15s on Sun, 17 Nov, 03:47 PM Test Summary: 1 of 49543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1527

  5. TYPO3com commented on patch set 1 11/17/19, 15:56 Completed build in 09m 57s on Sun, 17 Nov, 03:56 PM Test Summary: 50345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1528

  6. TYPO3com voted on patch set 1 V +1 11/17/19, 15:59 Completed build in 23m 48s on Sun, 17 Nov, 03:59 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1528

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 11/17/19, 16:08

  8. Daniel Goerz merged patch set 2 11/17/19, 16:08