Review 9.5 Abandoned

62283[TASK] Do not use constants in low-level classes

Susi Moog CR 0 V 0 Easy +14 −14 updated 11/20/19, 19:51

Commit message

There are certain PHP classes used in the testing framework that
use constants like "LF" which are defined by the SystemEnvironmentBuilder.

The testing framework depends on these classes, but should not
depend on global constants like "LF". The patch changes the lines to "\n"
allowing to continue slimming down testing framework.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 46

  1. Susi Moog commented on patch set 1 11/20/19, 14:19

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Utility/ArrayUtility.php
  2. TYPO3com voted on patch set 1 V -1 11/20/19, 14:19 Completed build in 17s on Wed, 20 Nov, 02:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1534

  3. Susi Moog commented on patch set 2 11/20/19, 14:21

    Published edit on patch set 1.
  4. Oliver Klee commented on patch set 2 11/20/19, 14:28

    ArrayUtility.php:476 Unresolved

    This line should be master-only.
  5. TYPO3com voted on patch set 2 V +1 11/20/19, 14:34 Completed build in 12m 40s on Wed, 20 Nov, 02:34 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1535

  6. Susi Moog abandoned the change 11/20/19, 19:51

    duplicate