Review 9.5 Merged

62284[BUGFIX] Do not add entries to cache_treelist when logged into BE

Benni Mack CR +2 V +2 Easy +10 −6 updated 11/20/19, 15:42

Commit message

When accessing cache_treelist / cObj->getTreeList()
this information should not be cached at all when logged
into the backend at the same time. This would then result
in wrong lists of IDs.

As treelist is conceptually wrong on a various number of levels,
a short workaround is added so the cache is never written
when accessing the Frontend and having a valid $GLOBALS['BE_USER']
object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 11/20/19, 15:28

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
  2. TYPO3com voted on patch set 1 V -1 11/20/19, 15:29 Completed build in 17s on Wed, 20 Nov, 03:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1536

  3. Benni Mack commented on patch set 2 11/20/19, 15:30

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 11/20/19, 15:30

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 11/20/19, 15:39 Completed build in 09m 20s on Wed, 20 Nov, 03:39 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1537

  6. Benni Mack voted on patch set 2 V +2 CR +2 11/20/19, 15:42

  7. Benni Mack merged patch set 3 11/20/19, 15:42