Review 9.5 Merged

62288[BUGFIX] Document unsetting array property items in form variants

Susi Moog CR +2 V +2 Normal +130 −0 updated 11/23/19, 13:45

Commit message

It is actually possible to unset array property items like select
options through the magic "__UNSET" feature of the core ArrayUtility.
This should be documented as such.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Susi Moog commented on patch set 1 11/21/19, 12:53

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/form/Documentation/I/Concepts/Variants/Index.rst
  2. TYPO3com voted on patch set 1 V +1 11/21/19, 13:03 Completed build in 09m 40s on Thu, 21 Nov, 01:03 PM Test Summary: 50979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1549

  3. Mathias Brodala voted on patch set 1 V +1 CR +1 11/21/19, 13:44

  4. Susi Moog commented on patch set 1 11/22/19, 17:07

    This change is ready for review.
  5. Susi Moog marked it work in progress 11/22/19, 17:07

  6. Björn Jacob commented on patch set 1 CR -1 11/23/19, 11:29

    On it.
  7. Björn Jacob uploaded patch set 2 11/23/19, 11:33

  8. Björn Jacob commented on patch set 2 V +1 CR +1 11/23/19, 11:34

    Resolved merge conflict manually.
  9. Susi Moog commented on patch set 2 11/23/19, 11:39

    This change is ready for review.
  10. Mathias Brodala commented on patch set 2 V +1 CR +1 11/23/19, 11:40

    Verified in master / by Bamboo.
  11. TYPO3com voted on patch set 2 V +1 11/23/19, 11:43 Completed build in 09m 49s on Sat, 23 Nov, 11:43 AM Test Summary: 50997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1570

  12. Ralf Zimmermann voted on patch set 2 V +2 CR +2 11/23/19, 13:45

  13. Ralf Zimmermann merged patch set 3 11/23/19, 13:45