Review 9.5 Merged

62289[BUGFIX] Fix PHP error in SoftReferenceParserHook for missing form definitions

Ralf Zimmermann CR +2 V +2 Easy +5 −0 updated 11/22/19, 09:41

Commit message

This patch adds a safe guard to make sure the `$file` object is not null
on trying to update the soft reference. This is necessary as
`ResourceFactory->retrieveFileOrFolderObject()` returns null instead of
throwing an exception in several cases (e.g. missing form definition
located in an extension).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Ralf Zimmermann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Ralf Zimmermann commented on patch set 1 11/21/19, 16:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/21/19, 16:24 Completed build in 10m 14s on Thu, 21 Nov, 04:24 PM Test Summary: 50975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1550

  3. Ralf Zimmermann voted on patch set 1 V +1 CR +1 11/21/19, 16:27

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/22/19, 09:41

  5. Benni Mack merged patch set 2 11/22/19, 09:41