Review 9.5 Merged

62290[TASK] Document variables assigned to mail templates

Benni Mack CR +2 V +2 Easy +22 −0 updated 11/22/19, 07:28

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Benni Mack +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack commented on patch set 1 11/21/19, 22:07

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/form/Documentation/I/ApiReference/Index.rst
  2. TYPO3com voted on patch set 1 V +1 11/21/19, 22:34 Completed build in 21m 33s on Thu, 21 Nov, 10:34 PM Test Summary: 50975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1551

  3. Björn Jacob commented on patch set 1 CR -1 11/21/19, 23:28

    The document is located here: https://github.com/TYPO3/TYPO3.CMS/tree/9.5/typo3/sysext/form/Documentation/ApiReference I.e., it already exists in the above mentioned folder. Please do not create a new folder.
  4. Björn Jacob uploaded patch set 2 11/22/19, 07:04

  5. Björn Jacob commented on patch set 2 V +1 CR +1 11/22/19, 07:08

    Moved stuff to the right position.
  6. TYPO3com voted on patch set 2 V +1 11/22/19, 07:14 Completed build in 09m 42s on Fri, 22 Nov, 07:14 AM Test Summary: 50975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1553

  7. Benni Mack commented on patch set 2 V +2 CR +2 11/22/19, 07:28

    This change is ready for review.
  8. Benni Mack merged patch set 3 11/22/19, 07:28