Review main Merged

62293[BUGFIX] Remove leading slash from backendLogo path

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 12/10/19, 11:16

Commit message

As the extension configuration field `backendLogo` isn't resolved
by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`,
it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage)
not possible to add a path with a leading slash.

As this is neither explicit allowed nor disallowed, this unifies the
behavior by removing a possible leading slash from the defined path
before it gets resolved as it's already the case for the other fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 714

  1. Oli Bartsch uploaded patch set 1 11/11/19, 09:40

  2. TYPO3com voted on patch set 1 V -1 11/11/19, 09:49 Completed build in 08m 29s on Mon, 11 Nov, 09:49 AM Test Summary: 48222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38266

  3. TYPO3com commented on patch set 1 11/11/19, 10:27 Completed build in 15m 45s on Mon, 11 Nov, 10:27 AM Test Summary: 1 of 48644 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38267

  4. TYPO3com commented on patch set 1 11/11/19, 10:44 Completed build in 11m 07s on Mon, 11 Nov, 10:44 AM Test Summary: 4 of 48656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38269

  5. TYPO3com commented on patch set 1 11/11/19, 12:32 Completed build in 07m 49s on Mon, 11 Nov, 12:32 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38270

  6. TYPO3com commented on patch set 1 11/11/19, 12:52 Completed build in 08m 42s on Mon, 11 Nov, 12:52 PM Test Summary: 35 of 48402 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38271

  7. TYPO3com voted on patch set 1 V +1 11/11/19, 13:20 Completed build in 45m 10s on Mon, 11 Nov, 01:20 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38271

  8. Benni Mack commented on patch set 1 11/11/19, 13:29

    Can you give an example on what should I add as "backendLogo" value?
  9. Oli Bartsch commented on patch set 1 11/11/19, 13:43

    > Patch Set 1: > > Can you give an example on what should I add as "backendLogo" value? E.g. one has an assets folder (independent of custom extensions) called "assets". So he could add following path to the backend.backendLogo field: `/assets/images/logos/custom-backend-logo.png`. Surely this is also valid for: `/fileadmin/images/logos/custom-backend-logo.png`. The main reason for this patch was that I wanted to use the same logo for backend.loginLogo as for backend.backendLogo. I therefore entered the same path in both fields but only the backend.loginLogo was displayed. It took me some time to find out that the problem was the the leading stash. So my intention is just to unify the behavior of the extConf fields of ext:backend. I'm aware that the description of this field says as example `fileadmin/..` without the leading slash but this is for me not really explicit because: 1. It's just an example 2. The same path worked for the other field
  10. Oli Bartsch updated the commit message in patch set 2 11/25/19, 10:00

  11. TYPO3com voted on patch set 2 V +1 11/25/19, 10:08 Completed build in 07m 15s on Mon, 25 Nov, 10:08 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38814

  12. Michael Telgkamp voted on patch set 2 V +1 CR +1 12/08/19, 07:03

  13. Benni Mack voted on patch set 2 V +2 CR +2 12/10/19, 11:16

  14. Benni Mack merged patch set 3 12/10/19, 11:16