Review main Merged

62295[TASK] Show manual link in the action "Installed Extensions"

Georg Ringer CR +2 V +2 Easy +17 −3 updated 01/15/20, 13:58

Commit message

The link to the documentation of an extension, which has been
added with #89458, is now displayed in the list of
"Installed Extensions" as well.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1926

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 11/11/19, 12:47

  1. Georg Ringer commented on patch set 1 11/11/19, 12:47

    This change is ready for review.
  2. TYPO3com voted on patch set 1 V -1 11/11/19, 12:55 Completed build in 08m 07s on Mon, 11 Nov, 12:55 PM Test Summary: 48045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38272

  3. TYPO3com voted on patch set 1 V +1 11/11/19, 13:05 Completed build in 25m 52s on Mon, 11 Nov, 01:05 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38272

  4. Oli Bartsch commented on patch set 1 11/11/19, 13:11

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:12

    Could we make a link out of it? -> `#89458 <Feature-89458-ShowLinkToOnlineDocsInExtensionManager.rst>`_

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:14

    Full stop is missing here.

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:20 Unresolved

    Maybe we could mention where exactly the information is displayed.
  5. Daniel Siepmann uploaded patch set 2 11/11/19, 13:21

  6. Daniel Siepmann commented on patch set 2 11/11/19, 13:21

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:12 Reply

    Done

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:14 Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 11/11/19, 13:28 Completed build in 07m 46s on Mon, 11 Nov, 01:28 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38273

  8. Sybille Peters commented on patch set 2 11/11/19, 13:48

    Feature-89640-ShowManualLinkInTheActionInstalledExtensions.rst:20 Unresolved

    Question for clarification: How this works is not clear to me. This is how I THINK it works: It is only necessary for extension authors to add a link to the manual if it is NOT rendered on docs.typo3.org with new rendering mechanism. If it is rendered on docs.typo3.org, extensions.typo3.org retrieves manual URL automatically. Then the author of the extension SHOULD NOT add a URL to external manual for his extension on TER. The information the BE retrieves from TER always contains correct URL to docs (if any is defined - either by default mechanism docs.typo3.org or by adding a custom URL on extensions.typo3.org). https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingDocForExtension/FAQ.html#should-i-add-a-link-to-the-documentation-in-ter If this is correct, then I would change the changelog to make that clearer. If you are not aware of the mechanism, it might read like you should always add a URL in order for the link to the manual to show in backend. The cool thing is that it should usually "just work" with the webhook for doc rendering and no additional setup is necessary.
  9. Markus Klein uploaded patch set 3 01/14/20, 21:07

  10. Markus Klein voted on patch set 3 V +1 CR +1 01/14/20, 21:07

  11. Markus Klein updated the commit message in patch set 4 01/14/20, 21:12

  12. Markus Klein voted on patch set 4 V +1 CR +1 01/14/20, 21:13

  13. Daniel Goerz voted on patch set 4 V +1 CR +1 01/14/20, 21:19

  14. TYPO3com voted on patch set 3 V +1 01/14/20, 21:33 Completed build in 22m 30s on Tue, 14 Jan, 09:33 PM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39944

  15. TYPO3com voted on patch set 4 V +1 01/14/20, 21:36 Completed build in 12m 08s on Tue, 14 Jan, 09:36 PM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39945

  16. Markus Klein commented on patch set 4 CR -1 01/14/20, 21:41

    improving rst
  17. Felix P. voted on patch set 4 V +1 CR +1 01/15/20, 07:42

  18. Daniel Goerz uploaded patch set 5 01/15/20, 12:22

  19. Daniel Goerz voted on patch set 5 V +1 CR +1 01/15/20, 12:23

  20. Daniel Goerz uploaded patch set 6 01/15/20, 12:24

  21. Daniel Goerz voted on patch set 6 V +1 CR +1 01/15/20, 12:25

  22. TYPO3com voted on patch set 5 V +1 01/15/20, 12:36 Completed build in 14m 04s on Wed, 15 Jan, 12:36 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39966

  23. TYPO3com voted on patch set 6 V +1 01/15/20, 12:42 Completed build in 14m 19s on Wed, 15 Jan, 12:42 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39967

  24. Susi Moog voted on patch set 6 V +2 CR +2 01/15/20, 13:58

  25. Susi Moog merged patch set 7 01/15/20, 13:58