62296[TASK] Remove unused log-related TYPO3_CONF_VARS
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Susi Moog +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −2
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −12
- typo3/sysext/core/Documentation/Changelog/master/Important-89645-RemovedSystemLogOptions.rstnew+29 −0
- typo3/sysext/install/Classes/Configuration/Context/CustomPreset.php+0 −1
- typo3/sysext/install/Classes/Configuration/Context/DebugPreset.php+0 −1
- typo3/sysext/install/Classes/Configuration/Context/LivePreset.php+0 −1
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+3 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+10 −0
- typo3/sysext/install/Resources/Public/JavaScript/Router.js+1 −1
Review log 1930
Show 35 earlier messages
-
Benni Mack uploaded patch set 1 11/11/19, 14:51
-
TYPO3com voted on patch set 1 V +1 11/11/19, 15:00 Completed build in 09m 12s on Mon, 11 Nov, 03:00 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38275
-
Benni Mack updated the commit message in patch set 2 11/12/19, 07:59
-
TYPO3com voted on patch set 2 V -1 11/12/19, 08:08 Completed build in 08m 17s on Tue, 12 Nov, 08:08 AM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38282
-
Benni Mack uploaded patch set 3 11/12/19, 08:38
-
TYPO3com voted on patch set 3 V -1 11/12/19, 08:46 Completed build in 08m 14s on Tue, 12 Nov, 08:46 AM Test Summary: 47893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38284
-
TYPO3com commented on patch set 3 11/12/19, 11:13 Completed build in 2h 43m 32s on Tue, 12 Nov, 11:13 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38284
-
Benni Mack commented on patch set 4 11/12/19, 12:13
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V -1 11/12/19, 12:21 Completed build in 08m 05s on Tue, 12 Nov, 12:21 PM Test Summary: 37600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294
-
TYPO3com commented on patch set 4 11/12/19, 12:43 Completed build in 38m 08s on Tue, 12 Nov, 12:43 PM Test Summary: 48295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294
-
TYPO3com voted on patch set 4 V +1 11/12/19, 15:31 Completed build in 3h 55m 49s on Tue, 12 Nov, 03:31 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294
-
Susi Moog uploaded patch set 5 11/13/19, 06:47
-
Susi Moog voted on patch set 5 V +1 CR +1 11/13/19, 06:47
-
TYPO3com voted on patch set 5 V -1 11/13/19, 06:54 Completed build in 07m 21s on Wed, 13 Nov, 06:54 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38322
-
Benni Mack commented on patch set 5 11/13/19, 07:38
Markus had some good feedback - He suggested to use an Important but not a deprecation file. -
Benni Mack voted on patch set 5 CR -1 11/13/19, 07:38
-
Susi Moog commented on patch set 5 11/13/19, 07:44
we also need to check the build result. something something line endings. -
Andreas Kienast commented on patch set 5 11/13/19, 07:56
Please do a `yarn install` to get the current build chain. There is actually a difference in the build, thus the failure. -
Andreas Kienast rebased onto patch set 6 11/13/19, 07:57
-
Andreas Kienast uploaded patch set 7 11/13/19, 07:58
-
Susi Moog commented on patch set 7 CR -1 11/13/19, 08:04
-1 for moving from deprecation to important rst -
TYPO3com voted on patch set 7 V +1 11/13/19, 08:06 Completed build in 08m 11s on Wed, 13 Nov, 08:06 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38327
-
Alexander Schnitzler voted on patch set 7 V +1 CR +1 11/13/19, 09:41
-
Alexander Schnitzler commented on patch set 7 11/13/19, 09:43
Unresolved
One remark: I'd change the commit message to "Remove unusued log related TYPO3_CONF_VARS" and be specific about which values exactly are to be removed in the commit description. That way it's easier to find when people search for systemLogLevel e.g. -
Benni Mack uploaded patch set 8 11/19/19, 08:12
-
TYPO3com voted on patch set 8 V -1 11/19/19, 08:19 Completed build in 07m 14s on Tue, 19 Nov, 08:19 AM Test Summary: 48051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38468
-
TYPO3com voted on patch set 8 V +1 11/19/19, 08:58 Completed build in 52m 48s on Tue, 19 Nov, 08:58 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38468
-
Alexander Schnitzler voted on patch set 8 V +1 CR +1 11/19/19, 19:42
-
Susi Moog voted on patch set 8 V +2 CR +2 11/20/19, 06:42
-
Susi Moog merged patch set 9 11/20/19, 06:42