Review main Merged

62296[TASK] Remove unused log-related TYPO3_CONF_VARS

Benni Mack CR +2 V +2 Normal +44 −19 updated 11/20/19, 06:42

Commit message

The options

- systemLog
- systemLogLevel

have been marked as unused with TYPO3 v9.0,
and should be removed from any upgrade installation via
the SilentConfigurationUpgrade system.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1930

Show 35 earlier messages
  1. Benni Mack uploaded patch set 1 11/11/19, 14:51

  2. TYPO3com voted on patch set 1 V +1 11/11/19, 15:00 Completed build in 09m 12s on Mon, 11 Nov, 03:00 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38275

  3. Benni Mack updated the commit message in patch set 2 11/12/19, 07:59

  4. TYPO3com voted on patch set 2 V -1 11/12/19, 08:08 Completed build in 08m 17s on Tue, 12 Nov, 08:08 AM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38282

  5. Benni Mack uploaded patch set 3 11/12/19, 08:38

  1. TYPO3com voted on patch set 3 V -1 11/12/19, 08:46 Completed build in 08m 14s on Tue, 12 Nov, 08:46 AM Test Summary: 47893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38284

  2. TYPO3com commented on patch set 3 11/12/19, 11:13 Completed build in 2h 43m 32s on Tue, 12 Nov, 11:13 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38284

  3. Benni Mack commented on patch set 4 11/12/19, 12:13

    Published edit on patch set 3.
  4. TYPO3com voted on patch set 4 V -1 11/12/19, 12:21 Completed build in 08m 05s on Tue, 12 Nov, 12:21 PM Test Summary: 37600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294

  5. TYPO3com commented on patch set 4 11/12/19, 12:43 Completed build in 38m 08s on Tue, 12 Nov, 12:43 PM Test Summary: 48295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294

  6. TYPO3com voted on patch set 4 V +1 11/12/19, 15:31 Completed build in 3h 55m 49s on Tue, 12 Nov, 03:31 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38294

  7. Susi Moog uploaded patch set 5 11/13/19, 06:47

  8. Susi Moog voted on patch set 5 V +1 CR +1 11/13/19, 06:47

  9. TYPO3com voted on patch set 5 V -1 11/13/19, 06:54 Completed build in 07m 21s on Wed, 13 Nov, 06:54 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38322

  10. Benni Mack commented on patch set 5 11/13/19, 07:38

    Markus had some good feedback - He suggested to use an Important but not a deprecation file.
  11. Benni Mack voted on patch set 5 CR -1 11/13/19, 07:38

  12. Susi Moog commented on patch set 5 11/13/19, 07:44

    we also need to check the build result. something something line endings.
  13. Andreas Kienast commented on patch set 5 11/13/19, 07:56

    Please do a `yarn install` to get the current build chain. There is actually a difference in the build, thus the failure.
  14. Andreas Kienast rebased onto patch set 6 11/13/19, 07:57

  15. Andreas Kienast uploaded patch set 7 11/13/19, 07:58

  16. Susi Moog commented on patch set 7 CR -1 11/13/19, 08:04

    -1 for moving from deprecation to important rst
  17. TYPO3com voted on patch set 7 V +1 11/13/19, 08:06 Completed build in 08m 11s on Wed, 13 Nov, 08:06 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38327

  18. Alexander Schnitzler voted on patch set 7 V +1 CR +1 11/13/19, 09:41

  19. Alexander Schnitzler commented on patch set 7 11/13/19, 09:43

    Unresolved

    One remark: I'd change the commit message to "Remove unusued log related TYPO3_CONF_VARS" and be specific about which values exactly are to be removed in the commit description. That way it's easier to find when people search for systemLogLevel e.g.
  20. Benni Mack uploaded patch set 8 11/19/19, 08:12

  21. TYPO3com voted on patch set 8 V -1 11/19/19, 08:19 Completed build in 07m 14s on Tue, 19 Nov, 08:19 AM Test Summary: 48051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38468

  22. TYPO3com voted on patch set 8 V +1 11/19/19, 08:58 Completed build in 52m 48s on Tue, 19 Nov, 08:58 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38468

  23. Alexander Schnitzler voted on patch set 8 V +1 CR +1 11/19/19, 19:42

  24. Susi Moog voted on patch set 8 V +2 CR +2 11/20/19, 06:42

  25. Susi Moog merged patch set 9 11/20/19, 06:42