Review main Merged

62298[FEATURE] Add argument "fields" to editRecord ViewHelpers

Sybille Peters CR +2 V +2 Normal +144 −0 updated 12/31/19, 13:26

Commit message

The <be:link.editRecord> and <be:url.editRecord> now have an option
argument "fields" which can be used to limit the edit form to only
these fields (instead of the entire record).

The fields should be passed in a comma separated list.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 2331

Show 46 earlier messages
  1. Sybille Peters uploaded patch set 1 11/11/19, 15:26

  2. TYPO3com voted on patch set 1 V +1 11/11/19, 15:34 Completed build in 08m 00s on Mon, 11 Nov, 03:34 PM Test Summary: 48302 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38278

  3. Georg Ringer commented on patch set 1 V +1 CR -1 11/12/19, 21:15

    Feature-89644-AddOptionalArgumentFieldsToEditRecordViewHelpers.rst:14

    this makes it possible to *create a link* to the FormEngine edit view to edit only specific fields I also would like to see an example of both VH calls in the rst!
  4. Sybille Peters uploaded patch set 2 11/14/19, 02:01

  5. Sybille Peters commented on patch set 2 11/14/19, 03:19

    Feature-89644-AddOptionalArgumentFieldsToEditRecordViewHelpers.rst:14 Reply

    Done I also added an example to the source comment.
  6. TYPO3com voted on patch set 2 V +1 11/14/19, 03:44 Completed build in 1h 05m 00s on Thu, 14 Nov, 03:44 AM Test Summary: 48326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38356

  1. Georg Ringer voted on patch set 2 V +1 CR +1 11/14/19, 04:33

  2. Oli Bartsch commented on patch set 2 CR -1 11/14/19, 06:23

    EditRecordViewHelper.php:54

    Wouldn’t that be `tt_content` in this example? But to unify with the existing examples I would also use `a_table` in the ViewHelper call.

    EditRecordViewHelper.php:71

    Because you use null coalescing I see no need for this default value as empty string should be checked with `!== ''` instead. So please either remove the default value, which I prefer or change the comparison.

    EditRecordViewHelper.php:46

    Also here.

    EditRecordViewHelper.php:56

    Same here.

    EditRecordViewHelper.php:56

    fields

    WithUidTableAndFields.html:2

    c_table:43
  3. Sybille Peters uploaded patch set 3 11/14/19, 08:24

  4. Sybille Peters commented on patch set 3 11/14/19, 08:24

    EditRecordViewHelper.php:71 Reply

    Done

    EditRecordViewHelper.php:46 Reply

    Done

    EditRecordViewHelper.php:56 Reply

    Done

    EditRecordViewHelper.php:56 Reply

    Done

    WithUidTableAndFields.html:2 Reply

    Done
  5. Sybille Peters commented on patch set 3 11/14/19, 08:25

    > Patch Set 3: > > (5 comments)

    EditRecordViewHelper.php:54 Reply

    Here, I wanted to use a "real" example to make it more intuitive so that people will hopefully right away understand what this refers to in a TYPO3 context - even without reading the description. I changed it to pages.title and subtitle now and corrected the discrepancies.
  6. TYPO3com voted on patch set 3 V -1 11/14/19, 08:31 Completed build in 07m 10s on Thu, 14 Nov, 08:31 AM Test Summary: 48326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38361

  7. Oli Bartsch commented on patch set 3 11/14/19, 08:32

    Looks good now. Only thing I noticed now, that we don't have a commit message which describes the feature well. Surely we have the rst file and the examples in the classes. But maybe you could add some short description in the commit message which I guess would help people a lot.

    EditRecordViewHelper.php:54 Reply

    Sure, sounds good and I'm totally fine with this change.
  8. Sybille Peters updated the commit message in patch set 4 11/14/19, 08:43

  9. Sybille Peters commented on patch set 4 CR -1 11/14/19, 08:48

    EditRecordViewHelper.php:54 Reply

    Done
  10. Sybille Peters uploaded patch set 5 11/14/19, 08:49

  11. Sybille Peters uploaded patch set 6 11/14/19, 08:50

  12. TYPO3com voted on patch set 4 V -1 11/14/19, 08:51 Completed build in 07m 46s on Thu, 14 Nov, 08:51 AM Test Summary: 48326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38362

  13. Sybille Peters commented on patch set 6 11/14/19, 08:52

    Accidentally committed extra file :( Is now fixed.
  14. TYPO3com voted on patch set 5 V -1 11/14/19, 08:57 Completed build in 08m 02s on Thu, 14 Nov, 08:57 AM Test Summary: 1 of 48685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38363

  15. TYPO3com voted on patch set 6 V +1 11/14/19, 09:00 Completed build in 09m 22s on Thu, 14 Nov, 09:00 AM Test Summary: 48326 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38364

  16. Oli Bartsch voted on patch set 6 V +1 CR +1 11/14/19, 09:14

  17. Tymoteusz Motylewski commented on patch set 6 11/17/19, 13:44

    Can we please also have a test for multiple fields (to make sure the comma separated list works)
  18. Sybille Peters uploaded patch set 7 11/23/19, 18:33

  19. Sybille Peters commented on patch set 7 11/23/19, 18:34

    > Patch Set 6: > > Can we please also have a test for multiple fields (to make sure the comma separated list works) Done.
  20. TYPO3com voted on patch set 7 V -1 11/23/19, 18:41 Completed build in 07m 36s on Sat, 23 Nov, 06:41 PM Test Summary: 47694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38783

  21. TYPO3com voted on patch set 7 V +1 11/23/19, 18:57 Completed build in 07m 30s on Sat, 23 Nov, 06:57 PM Test Summary: 48173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38784

  22. Oli Bartsch voted on patch set 7 V +1 CR +1 11/24/19, 00:02

  23. Daniel Siepmann commented on patch set 7 CR +1 12/02/19, 15:53

    Thanks, I needed this feature last week, after I've discovered the Functionality in EXT:feedit. So highly appreciated.
  24. Benni Mack voted on patch set 7 V +2 CR +2 12/31/19, 13:26

  25. Benni Mack merged patch set 8 12/31/19, 13:26