Review main Merged

62300[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8

Stephan Großberndt CR +2 V +2 Easy +1 −1 updated 11/12/19, 12:15

Commit message

This patch adds a cast to the property `$mask` before handing it over to
`IpAnonymizationUtility::anonymizeIp()` as this method requires `$mask`
to be an `int`. This is necessary as when the task was created and saved
in TYPO3 8 it was serialized as `string`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Stephan Großberndt uploaded patch set 1 11/12/19, 09:03

  2. TYPO3com voted on patch set 1 V -1 11/12/19, 09:11 Completed build in 07m 57s on Tue, 12 Nov, 09:11 AM Test Summary: 47765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38285

  3. TYPO3com commented on patch set 1 11/12/19, 09:33 Completed build in 07m 28s on Tue, 12 Nov, 09:33 AM Test Summary: 37947 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38286

  4. Oli Bartsch voted on patch set 1 CR +1 11/12/19, 10:15

  5. TYPO3com voted on patch set 1 V +1 11/12/19, 12:02 Completed build in 2h 44m 00s on Tue, 12 Nov, 12:02 PM Test Summary: 48295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38286

  6. Daniel Gorges voted on patch set 1 V +1 CR +1 11/12/19, 12:14

  7. Benni Mack voted on patch set 1 V +2 CR +2 11/12/19, 12:15

  8. Benni Mack merged patch set 2 11/12/19, 12:15