Review main Merged

62301[FEATURE] Allow line breaks in TCA descriptions

Johannes Schlier CR +2 V +2 Easy +22 −1 updated 01/22/20, 13:50

Commit message

This patch allows linebreaks within the TcaDescription element to
make longer description texts easier to read.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2130

Show 35 earlier messages
  1. Johannes Schlier uploaded patch set 1 11/12/19, 11:25

  2. Johannes Schlier rebased onto patch set 2 11/12/19, 11:26

  3. Mathias Brodala commented on patch set 2 V -1 11/12/19, 11:31

    Since this is a FEATURE, it needs an RST.
  4. TYPO3com voted on patch set 1 V -1 11/12/19, 11:35 Completed build in 10m 07s on Tue, 12 Nov, 11:35 AM Test Summary: 47803 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38287

  5. TYPO3com voted on patch set 2 V -1 11/12/19, 11:36 Completed build in 09m 21s on Tue, 12 Nov, 11:36 AM Test Summary: 25669 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38288

  1. Johannes Schlier rebased onto patch set 3 11/12/19, 11:49

  2. Johannes Schlier rebased onto patch set 4 11/12/19, 11:49

  3. Johannes Schlier uploaded patch set 5 11/12/19, 11:52

  4. Johannes Schlier rebased onto patch set 6 11/12/19, 11:52

  5. TYPO3com voted on patch set 6 V -1 11/12/19, 11:53 Completed build in 26s on Tue, 12 Nov, 11:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38292

  6. TYPO3com voted on patch set 3 V -1 11/12/19, 11:58 Completed build in 08m 41s on Tue, 12 Nov, 11:58 AM Test Summary: 47791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38289

  7. TYPO3com voted on patch set 4 V -1 11/12/19, 11:58 Completed build in 09m 10s on Tue, 12 Nov, 11:58 AM Test Summary: 24484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38290

  8. TYPO3com voted on patch set 5 V -1 11/12/19, 12:01 Completed build in 08m 42s on Tue, 12 Nov, 12:01 PM Test Summary: 35633 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38291

  9. Johannes Schlier marked it work in progress 11/12/19, 12:06

  10. Johannes Schlier wrote 11/12/19, 12:06

    Set private
  11. Johannes Schlier wrote 11/21/19, 15:00

    Unset private
  12. TYPO3com voted on patch set 6 V +1 01/22/20, 12:23 Completed build in 11m 14s on Wed, 22 Jan, 12:23 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40133

  13. Daniel Goerz commented on patch set 6 01/22/20, 12:24

    Hi Johannes, can you check with Benni whether this Feature is OK to backport into 9? Then you could remove the WIP status and we can get it in :)
  14. Johannes Schlier updated the commit message in patch set 7 01/22/20, 13:23

  15. Johannes Schlier commented on patch set 7 01/22/20, 13:23

    This change is ready for review.
  16. Johannes Schlier commented on patch set 7 01/22/20, 13:23

    v10 only
  17. Georg Ringer voted on patch set 7 V +1 CR +1 01/22/20, 13:24

  18. Georg Ringer commented on patch set 7 CR -1 01/22/20, 13:25

    Feature-89650-AllowLineBreaksInTCADescriptions.rst:12 Unresolved

    use :php:`nl2br()`
  19. Daniel Goerz commented on patch set 8 01/22/20, 13:38

    Published edit on patch set 7.
  20. Daniel Goerz voted on patch set 8 V +1 CR +1 01/22/20, 13:38

  21. TYPO3com voted on patch set 7 V +1 01/22/20, 13:39 Completed build in 15m 54s on Wed, 22 Jan, 01:39 PM Test Summary: 70542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40138

  22. Susi Moog voted on patch set 8 V +1 CR +1 01/22/20, 13:41

  23. TYPO3com voted on patch set 8 V +1 01/22/20, 13:47 Completed build in 09m 04s on Wed, 22 Jan, 01:47 PM Test Summary: 70544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40139

  24. Daniel Goerz voted on patch set 8 V +2 CR +2 01/22/20, 13:50

  25. Daniel Goerz merged patch set 9 01/22/20, 13:50