Review main Merged

62302[TASK] Move preparation of non-cacheable headerdata into TSFE

Benni Mack CR +2 V +2 Normal +42 −37 updated 11/12/19, 13:47

Commit message

In order to centralize USER_INT ("non-cacheables") into TSFE logic,
some functionality is moved into TSFE regarding headerData,
JS and CSS inclusions.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 812

  1. Benni Mack uploaded patch set 1 11/12/19, 12:09

  2. TYPO3com voted on patch set 1 V -1 11/12/19, 12:18 Completed build in 09m 05s on Tue, 12 Nov, 12:18 PM Test Summary: 9 of 48035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38293

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/12/19, 12:18

  4. Benni Mack uploaded patch set 2 11/12/19, 12:37

  5. Benni Mack uploaded patch set 3 11/12/19, 12:45

  6. TYPO3com voted on patch set 2 V -1 11/12/19, 12:47 Completed build in 09m 45s on Tue, 12 Nov, 12:47 PM Test Summary: 47763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38296

  7. TYPO3com voted on patch set 3 V -1 11/12/19, 12:53 Completed build in 07m 56s on Tue, 12 Nov, 12:53 PM Test Summary: 47770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38297

  8. TYPO3com voted on patch set 3 V +1 11/12/19, 13:01 Completed build in 24m 16s on Tue, 12 Nov, 01:01 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38297

  9. Daniel Gorges voted on patch set 3 V +1 CR +1 11/12/19, 13:17

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/12/19, 13:32

  11. Georg Ringer voted on patch set 3 V +2 CR +2 11/12/19, 13:46

  12. Georg Ringer merged patch set 4 11/12/19, 13:47