Review main Merged

62304[BUGFIX] Add empty alt attribute to decorative images

Michael Telgkamp CR +2 V +2 Easy +8 −8 updated 11/13/19, 08:10

Commit message

Decorative images should have an empty alt attribute to hide
them from screenreaders.
See https://www.w3.org/WAI/WCAG21/Techniques/failures/F38

This patch adds the attribute to the images generated by the
icon provider classes using <img> tags.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2227

Show 12 earlier messages
  1. Michael Telgkamp uploaded patch set 1 11/12/19, 13:52

  2. TYPO3com voted on patch set 1 V -1 11/12/19, 14:00 Completed build in 08m 14s on Tue, 12 Nov, 02:00 PM Test Summary: 46604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38300

  1. Oliver Klee voted on patch set 1 CR +1 11/12/19, 14:08

  2. Michael Telgkamp updated the commit message in patch set 2 11/12/19, 14:17

  3. TYPO3com voted on patch set 2 V +1 11/12/19, 14:31 Completed build in 13m 27s on Tue, 12 Nov, 02:31 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38303

  4. Michael Telgkamp wrote 11/12/19, 14:31

    Topic set to accessibility
  5. Christian Wolff voted on patch set 2 CR +1 11/12/19, 14:48

  6. Thomas W. voted on patch set 2 CR +1 11/12/19, 14:56

  7. Chris Müller commented on patch set 2 11/12/19, 14:57

    BitmapIconProvider.php:58

    Please remove also the closing / -> this is not needed with HTML5

    SvgIconProvider.php:58

    Same here, please remove / at the end.
  8. Oli Bartsch commented on patch set 2 11/12/19, 14:59

    May you could add the reason here why this is an improvement respectively what the benefit is (ignored by screenreaders).
  9. Michael Telgkamp uploaded patch set 3 11/12/19, 15:02

  10. Oliver Klee voted on patch set 3 CR +1 11/12/19, 15:06

  11. Michael Telgkamp updated the commit message in patch set 4 11/12/19, 15:09

  12. Michael Telgkamp commented on patch set 4 11/12/19, 15:11

    Reply

    I added a note in patchset 4.

    BitmapIconProvider.php:58 Reply

    Thank you for the hint. I changed it for all occurrences.

    SvgIconProvider.php:58 Reply

    Done
  13. TYPO3com voted on patch set 3 V +1 11/12/19, 15:18 Completed build in 16m 23s on Tue, 12 Nov, 03:18 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38305

  14. Oliver Klee voted on patch set 4 CR +1 11/12/19, 15:24

  15. TYPO3com voted on patch set 4 V +1 11/12/19, 15:29 Completed build in 16m 28s on Tue, 12 Nov, 03:29 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38306

  16. Georg Ringer voted on patch set 4 V +1 CR +1 11/12/19, 19:15

  17. Chris Müller voted on patch set 4 CR +1 11/12/19, 19:25

  18. Oli Bartsch voted on patch set 4 CR +1 11/13/19, 05:10

  19. Frank Nägler commented on patch set 4 CR -1 11/13/19, 07:26

    please don't remove the self-closing tag, in XML context the closing tag is very important.
  20. Michael Telgkamp uploaded patch set 5 11/13/19, 07:54

  21. Michael Telgkamp commented on patch set 5 11/13/19, 07:55

    > Patch Set 4: Code-Review-1 > > please don't remove the self-closing tag, in XML context the closing tag is very important. I added the self-closing tag again. Thank you Frank for the note on XML context. I was not aware of it.
  22. TYPO3com voted on patch set 5 V +1 11/13/19, 08:03 Completed build in 09m 16s on Wed, 13 Nov, 08:03 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38325

  23. Frank Nägler commented on patch set 5 V +1 CR +1 11/13/19, 08:07

    > I added the self-closing tag again. Thank you Frank for the note on XML context. I was not aware of it. No problem :) Thx for adding it again, looks good now.
  24. Georg Ringer voted on patch set 5 V +2 CR +2 11/13/19, 08:10

  25. Georg Ringer merged patch set 6 11/13/19, 08:10