62304[BUGFIX] Add empty alt attribute to decorative images
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Frank Nägler +1
-
Verified V +2 Done
- Georg Ringer +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Imaging/IconProvider/BitmapIconProvider.php2+1 −1
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgIconProvider.php2+1 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php+3 −3
Review log 2227
Show 12 earlier messages
-
Michael Telgkamp uploaded patch set 1 11/12/19, 13:52
-
TYPO3com voted on patch set 1 V -1 11/12/19, 14:00 Completed build in 08m 14s on Tue, 12 Nov, 02:00 PM Test Summary: 46604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38300
-
Oliver Klee voted on patch set 1 CR +1 11/12/19, 14:08
-
Michael Telgkamp updated the commit message in patch set 2 11/12/19, 14:17
-
TYPO3com voted on patch set 2 V +1 11/12/19, 14:31 Completed build in 13m 27s on Tue, 12 Nov, 02:31 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38303
-
Michael Telgkamp wrote 11/12/19, 14:31
Topic set to accessibility -
Christian Wolff voted on patch set 2 CR +1 11/12/19, 14:48
-
Thomas W. voted on patch set 2 CR +1 11/12/19, 14:56
-
Chris Müller commented on patch set 2 11/12/19, 14:57
BitmapIconProvider.php:58Please remove also the closing / -> this is not needed with HTML5SvgIconProvider.php:58Same here, please remove / at the end. -
Oli Bartsch commented on patch set 2 11/12/19, 14:59
May you could add the reason here why this is an improvement respectively what the benefit is (ignored by screenreaders). -
Michael Telgkamp uploaded patch set 3 11/12/19, 15:02
-
Oliver Klee voted on patch set 3 CR +1 11/12/19, 15:06
-
Michael Telgkamp updated the commit message in patch set 4 11/12/19, 15:09
-
Michael Telgkamp commented on patch set 4 11/12/19, 15:11
Reply
I added a note in patchset 4.BitmapIconProvider.php:58ReplyThank you for the hint. I changed it for all occurrences.SvgIconProvider.php:58ReplyDone -
TYPO3com voted on patch set 3 V +1 11/12/19, 15:18 Completed build in 16m 23s on Tue, 12 Nov, 03:18 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38305
-
Oliver Klee voted on patch set 4 CR +1 11/12/19, 15:24
-
TYPO3com voted on patch set 4 V +1 11/12/19, 15:29 Completed build in 16m 28s on Tue, 12 Nov, 03:29 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38306
-
Georg Ringer voted on patch set 4 V +1 CR +1 11/12/19, 19:15
-
Chris Müller voted on patch set 4 CR +1 11/12/19, 19:25
-
Oli Bartsch voted on patch set 4 CR +1 11/13/19, 05:10
-
Frank Nägler commented on patch set 4 CR -1 11/13/19, 07:26
please don't remove the self-closing tag, in XML context the closing tag is very important. -
Michael Telgkamp uploaded patch set 5 11/13/19, 07:54
-
Michael Telgkamp commented on patch set 5 11/13/19, 07:55
> Patch Set 4: Code-Review-1 > > please don't remove the self-closing tag, in XML context the closing tag is very important. I added the self-closing tag again. Thank you Frank for the note on XML context. I was not aware of it. -
TYPO3com voted on patch set 5 V +1 11/13/19, 08:03 Completed build in 09m 16s on Wed, 13 Nov, 08:03 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38325
-
Frank Nägler commented on patch set 5 V +1 CR +1 11/13/19, 08:07
> I added the self-closing tag again. Thank you Frank for the note on XML context. I was not aware of it. No problem :) Thx for adding it again, looks good now. -
Georg Ringer voted on patch set 5 V +2 CR +2 11/13/19, 08:10
-
Georg Ringer merged patch set 6 11/13/19, 08:10